Fix stream load failure and insert failure in regression testing. #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure when it contains subquery
imay
requested changes
Nov 28, 2018
| } else if (dstType != srcType) { | ||
| CastExpr castExpr = (CastExpr)expr.castTo(slotDesc.getType()); | ||
| return castExpr; | ||
| if (dstType != srcType) { |
There was a problem hiding this comment.
why you delete origin stringType check
stringType check is used to make work with char and varchar, do you have test your path with char and varchar type with convert function which return is not these type?
There was a problem hiding this comment.
It won't produce CastExpr, when source and target are char or varchar, they are all treated as String in CastFunction. Expr has handled it in member function 'castTo'. And i have tested cases that table's attribute types contain char or varchar.
|
@chenhao7253886 |
chenhao7253886
changed the title
imay
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lure when it contains subquery