Skip to content

[fix](group commit) Add retry when delete bitmap lock expired on group commit #37600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[fix](group commit) Add retry when delete bitmap lock expired on group commit #37600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad5849
[fix](group commit) Add retry when delete bitmap lock expired on grou…
hust-hhb Jul 10, 2024
c5bf8f9
fix complie error
hust-hhb Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions be/src/runtime/group_commit_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <chrono>

#include "client_cache.h"
#include "cloud/config.h"
#include "common/compiler_util.h"
#include "common/config.h"
#include "common/status.h"
Expand Down Expand Up @@ -446,13 +447,26 @@ Status GroupCommitTable::_finish_group_commit_load(int64_t db_id, int64_t table_
}
TLoadTxnCommitResult result;
TNetworkAddress master_addr = _exec_env->master_info()->network_address;
st = ThriftRpcHelper::rpc<FrontendServiceClient>(
master_addr.hostname, master_addr.port,
[&request, &result](FrontendServiceConnection& client) {
client->loadTxnCommit(result, request);
},
10000L);
result_status = Status::create(result.status);
int retry_times = 0;
while (retry_times < config::mow_stream_load_commit_retry_times) {
st = ThriftRpcHelper::rpc<FrontendServiceClient>(
master_addr.hostname, master_addr.port,
[&request, &result](FrontendServiceConnection& client) {
client->loadTxnCommit(result, request);
},
10000L);
result_status = Status::create(result.status);
// DELETE_BITMAP_LOCK_ERROR will be retried
if (result_status.ok() || !result_status.is<ErrorCode::DELETE_BITMAP_LOCK_ERROR>()) {
break;
}
LOG_WARNING("Failed to commit txn on group commit")
.tag("label", label)
.tag("txn_id", txn_id)
.tag("retry_times", retry_times)
.error(result_status);
retry_times++;
}
} else {
// abort txn
TLoadTxnRollbackRequest request;
Expand Down