[Fix](function) fix some date function impl in FE with special dates #37766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40176 ms |
TPC-DS: Total hot run time: 172850 ms |
ClickBench: Total hot run time: 31 s |
morrySnow
previously approved these changes
Jul 17, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 39546 ms |
TPC-DS: Total hot run time: 172953 ms |
ClickBench: Total hot run time: 30.41 s |
|
run buildall |
TPC-H: Total hot run time: 39793 ms |
TPC-DS: Total hot run time: 172113 ms |
ClickBench: Total hot run time: 30.5 s |
zhangstar333
approved these changes
Jul 18, 2024
HappenLee
requested changes
Jul 18, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 22, 2024
…37766) make `dayofyear`, `dayofweek`, `weekofyear` result of FE folding constant result same with MySQL. mainly about date in BC01 (year `0000`) before: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ``` after: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ```
Closed
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Feb 7, 2025
…pache#37766) make `dayofyear`, `dayofweek`, `weekofyear` result of FE folding constant result same with MySQL. mainly about date in BC01 (year `0000`) before: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ``` after: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
make
dayofyear,dayofweek,weekofyearresult of FE folding constant result same with MySQL. mainly about date in BC01 (year0000)before:
after: