[opt](arm)Remove negative optimizations of SSE2NEON on memcmp for ARM #38759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41755 ms |
TPC-DS: Total hot run time: 170049 ms |
ClickBench: Total hot run time: 30.15 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38153 ms |
|
run performance |
TPC-H: Total hot run time: 38176 ms |
TPC-DS: Total hot run time: 195793 ms |
ClickBench: Total hot run time: 31.74 s |
zclllyybb
approved these changes
Aug 19, 2024
zhangstar333
approved these changes
Aug 19, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…#38759) The main issue is that _mm_movemask_epi8 does not have a one-to-one corresponding instruction on ARM. Testing shows that it performs worse compared to using memcmp, which allows the compiler to generate the corresponding ARM instructions. The following tests were conducted on ARM. ``` -------------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------------- BM_memequal16_sse 3.77 ns 3.77 ns 743238946 BM_memequal16_orgin 2.11 ns 2.11 ns 1000000000 ```
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
Nov 8, 2024
…apache#38759) The main issue is that _mm_movemask_epi8 does not have a one-to-one corresponding instruction on ARM. Testing shows that it performs worse compared to using memcmp, which allows the compiler to generate the corresponding ARM instructions. The following tests were conducted on ARM. ``` -------------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------------- BM_memequal16_sse 3.77 ns 3.77 ns 743238946 BM_memequal16_orgin 2.11 ns 2.11 ns 1000000000 ```
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Nov 10, 2024
#43510) … (#38759) #38759 The main issue is that _mm_movemask_epi8 does not have a one-to-one corresponding instruction on ARM. Testing shows that it performs worse compared to using memcmp, which allows the compiler to generate the corresponding ARM instructions. The following tests were conducted on ARM. ``` -------------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------------- BM_memequal16_sse 3.77 ns 3.77 ns 743238946 BM_memequal16_orgin 2.11 ns 2.11 ns 1000000000 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is that _mm_movemask_epi8 does not have a one-to-one corresponding instruction on ARM. Testing shows that it performs worse compared to using memcmp, which allows the compiler to generate the corresponding ARM instructions.
The following tests were conducted on ARM.