[improvement](jdbc catalog) Force all resources to be closed in the close method #39423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38807 ms |
TPC-DS: Total hot run time: 191126 ms |
ClickBench: Total hot run time: 31.03 s |
|
run buildall |
TPC-H: Total hot run time: 38690 ms |
TPC-DS: Total hot run time: 195401 ms |
ClickBench: Total hot run time: 31.15 s |
|
run buildall |
TPC-H: Total hot run time: 38387 ms |
TPC-DS: Total hot run time: 195453 ms |
ClickBench: Total hot run time: 32.03 s |
CalvinKirs
approved these changes
Aug 20, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Aug 21, 2024
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Aug 21, 2024
…lose method (apache#39423) Force all resources to be closed in the close method. In the previous logic, query errors or query cancellation will not force the connection to be closed, which will cause abnormal Hikari connection counts. Although forced connection closure will generate some error logs in some cases, we should have this bottom-line guarantee and refine the closing logic later.
zy-kkk
added a commit
that referenced
this pull request
Aug 22, 2024
…sed in the close method (#39665) pick #39423 Force all resources to be closed in the close method. In the previous logic, query errors or query cancellation will not force the connection to be closed, which will cause abnormal Hikari connection counts. Although forced connection closure will generate some error logs in some cases, we should have this bottom-line guarantee and refine the closing logic later
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
…lose method (#39423) Force all resources to be closed in the close method. In the previous logic, query errors or query cancellation will not force the connection to be closed, which will cause abnormal Hikari connection counts. Although forced connection closure will generate some error logs in some cases, we should have this bottom-line guarantee and refine the closing logic later.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
…sed in the close method (apache#39665) pick apache#39423 Force all resources to be closed in the close method. In the previous logic, query errors or query cancellation will not force the connection to be closed, which will cause abnormal Hikari connection counts. Although forced connection closure will generate some error logs in some cases, we should have this bottom-line guarantee and refine the closing logic later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force all resources to be closed in the close method. In the previous logic, query errors or query cancellation will not force the connection to be closed, which will cause abnormal Hikari connection counts. Although forced connection closure will generate some error logs in some cases, we should have this bottom-line guarantee and refine the closing logic later.