Skip to content

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

pick #39306

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

} else {
RETURN_IF_ERROR(partition_sort_read(block, eos, state->batch_size()));
}
RETURN_IF_ERROR(partition_sort_read(block, eos, state->batch_size()));
}
return Status::OK();
}

Status PartitionSorter::partition_sort_read(Block* output_block, bool* eos, int batch_size) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'partition_sort_read' has cognitive complexity of 55 (threshold 50) [readability-function-cognitive-complexity]

Status PartitionSorter::partition_sort_read(Block* output_block, bool* eos, int batch_size) {
                        ^
Additional context

be/src/vec/common/sort/partition_sorter.cpp:97: +1, including nesting penalty of 0, nesting level increased to 1

    if (priority_queue.empty()) {
    ^

be/src/vec/common/sort/partition_sorter.cpp:109: +1, including nesting penalty of 0, nesting level increased to 1

    while (!priority_queue.empty()) {
    ^

be/src/vec/common/sort/partition_sorter.cpp:112: +2, including nesting penalty of 1, nesting level increased to 2

        if (UNLIKELY(_previous_row->impl == nullptr)) {
        ^

be/src/vec/common/sort/partition_sorter.cpp:116: +2, including nesting penalty of 1, nesting level increased to 2

        switch (_top_n_algorithm) {
        ^

be/src/vec/common/sort/partition_sorter.cpp:119: +3, including nesting penalty of 2, nesting level increased to 3

            if ((current_output_rows + _output_total_rows) < _partition_inner_limit) {
            ^

be/src/vec/common/sort/partition_sorter.cpp:120: +4, including nesting penalty of 3, nesting level increased to 4

                for (size_t i = 0; i < num_columns; ++i) {
                ^

be/src/vec/common/sort/partition_sorter.cpp:123: +1, nesting level increased to 3

            } else {
              ^

be/src/vec/common/sort/partition_sorter.cpp:135: +3, including nesting penalty of 2, nesting level increased to 3

            if (_has_global_limit &&
            ^

be/src/vec/common/sort/partition_sorter.cpp:135: +1

            if (_has_global_limit &&
                                  ^

be/src/vec/common/sort/partition_sorter.cpp:140: +3, including nesting penalty of 2, nesting level increased to 3

            if (_has_global_limit) {
            ^

be/src/vec/common/sort/partition_sorter.cpp:142: +1, nesting level increased to 3

            } else {
              ^

be/src/vec/common/sort/partition_sorter.cpp:145: +4, including nesting penalty of 3, nesting level increased to 4

                if (cmp_res == false) {
                ^

be/src/vec/common/sort/partition_sorter.cpp:147: +5, including nesting penalty of 4, nesting level increased to 5

                    if (_output_distinct_rows >= _partition_inner_limit) {
                    ^

be/src/vec/common/sort/partition_sorter.cpp:154: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t i = 0; i < num_columns; ++i) {
            ^

be/src/vec/common/sort/partition_sorter.cpp:164: +3, including nesting penalty of 2, nesting level increased to 3

            if (_has_global_limit &&
            ^

be/src/vec/common/sort/partition_sorter.cpp:164: +1

            if (_has_global_limit &&
                                  ^

be/src/vec/common/sort/partition_sorter.cpp:171: +3, including nesting penalty of 2, nesting level increased to 3

            if (cmp_res == false) {
            ^

be/src/vec/common/sort/partition_sorter.cpp:173: +4, including nesting penalty of 3, nesting level increased to 4

                if ((current_output_rows + _output_total_rows) >= _partition_inner_limit) {
                ^

be/src/vec/common/sort/partition_sorter.cpp:179: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t i = 0; i < num_columns; ++i) {
            ^

be/src/vec/common/sort/partition_sorter.cpp:189: +2, including nesting penalty of 1, nesting level increased to 2

        if (!current->is_last()) {
        ^

be/src/vec/common/sort/partition_sorter.cpp:194: +2, including nesting penalty of 1, nesting level increased to 2

        if (current_output_rows == batch_size || get_enough_data == true) {
        ^

be/src/vec/common/sort/partition_sorter.cpp:194: +1

        if (current_output_rows == batch_size || get_enough_data == true) {
                                              ^

be/src/vec/common/sort/partition_sorter.cpp:200: +1, including nesting penalty of 0, nesting level increased to 1

    if (current_output_rows == 0 || get_enough_data == true) {
    ^

be/src/vec/common/sort/partition_sorter.cpp:200: +1

    if (current_output_rows == 0 || get_enough_data == true) {
                                 ^

@yiguolei yiguolei merged commit 3ac8347 into apache:branch-2.1 Aug 30, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants