[Enhancement] support last_query_id function #40739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
morrySnow
reviewed
Sep 12, 2024
| @@ -322,6 +322,7 @@ KILL: 'KILL'; | |||
| LABEL: 'LABEL'; | |||
| LARGEINT: 'LARGEINT'; | |||
| LAST: 'LAST'; | |||
| LAST_QUERY_ID: 'LAST_QUERY_ID'; | |||
There was a problem hiding this comment.
i think we should not support use this function without parentheses, so add this to keyword list is not necessary
| @@ -879,6 +883,10 @@ public TUniqueId queryId() { | |||
| return queryId; | |||
| } | |||
|
|
|||
| public TUniqueId getLastQuerId() { | |||
There was a problem hiding this comment.
Suggested change
| public TUniqueId getLastQuerId() { | |
| public TUniqueId getLastQueryId() { |
Vallishp
force-pushed
the
support_last_query_id
branch
from
e9e36aa to
2e74ecf
Compare
TPC-H: Total hot run time: 39733 ms |
|
run buildall |
TPC-H: Total hot run time: 43610 ms |
TPC-DS: Total hot run time: 195561 ms |
ClickBench: Total hot run time: 31.11 s |
yiguolei
previously approved these changes
Sep 12, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Sep 13, 2024
There was a problem hiding this comment.
all changes this file are not necessary
Vallishp
force-pushed
the
support_last_query_id
branch
from
2e74ecf to
0e07775
Compare
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 42666 ms |
TPC-DS: Total hot run time: 199576 ms |
ClickBench: Total hot run time: 31.09 s |
yiguolei
approved these changes
Sep 14, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
Sep 19, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
support display previous query id. mysql> select LAST_QUERY_ID(); No connection. Trying to reconnect... Connection id: 0 Current database: *** NONE *** +-----------------+ | last_query_id() | +-----------------+ | Not Available | +-----------------+ 1 row in set (0.08 sec) mysql> select LAST_QUERY_ID(); +-----------------------------------+ | last_query_id() | +-----------------------------------+ | e133f2641e0a411c-b73f1f6c67bedcf9 | +-----------------------------------+ 1 row in set (0.01 sec)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
support display previous query id.
mysql> select LAST_QUERY_ID();
No connection. Trying to reconnect...
Connection id: 0
Current database: *** NONE ***
+-----------------+
| last_query_id() |
+-----------------+
| Not Available |
+-----------------+
1 row in set (0.08 sec)
mysql> select LAST_QUERY_ID();
+-----------------------------------+
| last_query_id() |
+-----------------------------------+
| e133f2641e0a411c-b73f1f6c67bedcf9 |
+-----------------------------------+
1 row in set (0.01 sec)
mysql>