[improvement](tablet scheduler) fix higher priority tablet add failed due to pending queue full #41076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
yujun777
changed the title
|
run buildall |
deardeng
reviewed
Sep 23, 2024
fe/fe-core/src/main/java/org/apache/doris/clone/ColocateTableCheckerAndBalancer.java
Show resolved
Hide resolved
| if (!force && (pendingTablets.size() >= Config.max_scheduling_tablets | ||
| || runningTablets.size() >= Config.max_scheduling_tablets)) { | ||
| TabletSchedCtx lowestPriorityTablet = pendingTablets.peekLast(); | ||
| if (lowestPriorityTablet == null || lowestPriorityTablet.compareTo(tablet) <= 0) { |
|
run buildall |
|
PR approved by anyone and no changes requested. |
|
run p0 |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Sep 25, 2024
… due to pending queue full (apache#41076) When tablet checker search for unhealth tablets, it will search table one by one. If the pending queue is full, then the later search tablets couldn't add into the pending queue, even if they are higher priorty. So we use a minmax queue to holding the tablets. If a tablet is higher priority and the pending queue is full, it will envit the lowest priority tablet in the queue, then add this tablet into queue; other: 1. increase mow version incomplete task sched priority;
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
… due to pending queue full (#41076) When tablet checker search for unhealth tablets, it will search table one by one. If the pending queue is full, then the later search tablets couldn't add into the pending queue, even if they are higher priorty. So we use a minmax queue to holding the tablets. If a tablet is higher priority and the pending queue is full, it will envit the lowest priority tablet in the queue, then add this tablet into queue; other: 1. increase mow version incomplete task sched priority;
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Oct 18, 2024
… due to pending queue full apache#41076 (apache#41268) cherry pick from apache#41076
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tablet checker search for unhealth tablets, it will search table one by one. If the pending queue is full, then the later search tablets couldn't add into the pending queue, even if they are higher priorty. So we use a minmax queue to holding the tablets. If a tablet is higher priority and the pending queue is full, it will envit the lowest priority tablet in the queue, then add this tablet into queue;
other: