[fix](cloud-mow) MS should delete the existing keys before rewriting it when processing old version delete bitmap on cu compaction #42379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41147 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192399 ms |
ClickBench: Total hot run time: 32.27 s |
|
run buildall |
TPC-H: Total hot run time: 41566 ms |
|
TeamCity be ut coverage result: |
hust-hhb
changed the title
TPC-DS: Total hot run time: 191310 ms |
ClickBench: Total hot run time: 32.43 s |
zhannngchen
reviewed
Oct 25, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1853,6 +1856,143 @@ void MetaServiceImpl::update_delete_bitmap(google::protobuf::RpcController* cont | |||
| << " total_size=" << total_size << " unlock=" << unlock; | |||
| } | |||
|
|
|||
| void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController* controller, | |||
There was a problem hiding this comment.
warning: function 'update_delete_bitmap2' exceeds recommended size/complexity thresholds [readability-function-size]
void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController* controller,
^Additional context
cloud/src/meta-service/meta_service.cpp:1858: 132 lines including whitespace and comments (threshold 80)
void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController* controller,
^
hust-hhb
changed the title
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
1 similar comment
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
…itmap when doing cu compaction
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41591 ms |
TPC-DS: Total hot run time: 197711 ms |
ClickBench: Total hot run time: 32.38 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41684 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196504 ms |
ClickBench: Total hot run time: 32.66 s |
zhannngchen
approved these changes
Nov 6, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
gavinchou
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr #40204 support deleting old version delete bitmap when doing cu compaction, it will update delete bitmap with agg result, then deleting old version delete bitmap. Updating delete bitmap means overwriting existing keys, however delete bitmap may split into multiple kvs to store in fdb, so we should delete the existing keys and rewrite it to fdb instead of overwriting directly.