Skip to content

Conversation

hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Nov 6, 2024

What problem does this PR solve?

Related PR: #43261

Problem Summary:
pr #43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix this problem

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Nov 6, 2024

run buildall

Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.88% (9849/26000)
Line Coverage: 29.03% (81870/282031)
Region Coverage: 28.27% (42194/149243)
Branch Coverage: 24.85% (21401/86138)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e746e1ab46e526f3ca3033f54ba6479ead25bc20_e746e1ab46e526f3ca3033f54ba6479ead25bc20/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a586bac into apache:master Nov 6, 2024
26 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
…g delete bitmap fail and retry (#43457)

pr #43261 doesn't clear
GetDeleteBitmapResponse correctly, this pr fix this problem
pick pr #43358

Co-authored-by: huanghaibin <[email protected]>
@gavinchou gavinchou added the cir label Nov 11, 2024
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
…g delete bitmap fail and retry (apache#43358)

Problem Summary:
pr apache#43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix
this problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. cir dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants