Skip to content

[improvement](statistics)Skip auto analyze empty table. #43865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

[improvement](statistics)Skip auto analyze empty table. #43865

merged 1 commit into from
Nov 15, 2024

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Nov 13, 2024 •
edited
Loading

What problem does this PR solve?

When doing auto analyze, skip the table if the row count of this table is empty. This is more safe than write all 0 stats for this empty table, because the row count reported by BE is not realtime.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review November 13, 2024 07:44
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@Jibing-Li Jibing-Li merged commit be9524c into apache:master Nov 15, 2024
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
@Jibing-Li
[improvement](statistics)Skip auto analyze empty table. (#43865)
d6e10ca 
### What problem does this PR solve?

When doing auto analyze, skip the table if the row count of this table
is empty. This is more safe than write all 0 stats for this empty table,
because the row count reported by BE is not realtime.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Merged
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Nov 15, 2024
@Jibing-Li
Skip auto analyze empty table. (apache#43865)
7fa48c9
@Jibing-Li Jibing-Li mentioned this pull request Nov 15, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 15, 2024
@github-actions @Jibing-Li
branch-3.0: [improvement](statistics)Skip auto analyze empty table. #…
415d9e0 
…43865 (#44035)

Cherry-picked from #43865

Co-authored-by: James <[email protected]>
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Nov 15, 2024
@Jibing-Li
Skip auto analyze empty table. (apache#43865)
c2320e2
Jibing-Li added a commit that referenced this pull request Nov 16, 2024
@Jibing-Li
[improvement](statistics)Skip auto analyze empty table. (#43865) (#44045
f20aff5 
)

backport: #43865
@Jibing-Li Jibing-Li deleted the empty branch November 18, 2024 01:47
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Nov 18, 2024
@Jibing-Li
[improvement](statistics)Skip auto analyze empty table. (apache#43865) (
170b0f3 
apache#44045)

backport: apache#43865
@Jibing-Li Jibing-Li mentioned this pull request Nov 18, 2024
Merged
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Nov 18, 2024
@Jibing-Li
[improvement](statistics)Skip auto analyze empty table. (apache#43865) (
40b821d 
apache#44045)

backport: apache#43865
Jibing-Li added a commit that referenced this pull request Nov 18, 2024
@Jibing-Li
[improvement](statistics)Skip auto analyze empty table. (#43865) (#44099
1fb1f3b 
)

backport: #43865
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@xzj7019 xzj7019 xzj7019 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibing-Li @doris-robot @morrySnow @xzj7019 @dataroaring