Skip to content

[mysql]fix duplicate split request for newly added table #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022
Merged

[mysql]fix duplicate split request for newly added table #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9c473
[mysql] Avoid duplicate split requests when add new table (#1156)
Apr 14, 2022
b61c748
[mysql] Avoid duplicate split requests when add new table.(#1156)
leonardBang Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/SnapshotSplitReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
import javax.annotation.Nullable;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ExecutorService;
Expand Down Expand Up @@ -247,7 +247,7 @@ public Iterator<SourceRecords> pollSplitRecords() throws InterruptedException {
boolean reachBinlogEnd = false;
SourceRecord lowWatermark = null;
SourceRecord highWatermark = null;
Map<Struct, SourceRecord> snapshotRecords = new HashMap<>();
Map<Struct, SourceRecord> snapshotRecords = new LinkedHashMap<>();
while (!reachBinlogEnd) {
checkReadException();
List<DataChangeEvent> batch = queue.poll();
Expand Down
8 changes: 7 additions & 1 deletion ...cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public List<MySqlSplit> snapshotState(long checkpointId) {

@Override
protected void onSplitFinished(Map<String, MySqlSplitState> finishedSplitIds) {
boolean requestNextSplit = true;
for (MySqlSplitState mySqlSplitState : finishedSplitIds.values()) {
MySqlSplit mySqlSplit = mySqlSplitState.toMySqlSplit();
if (mySqlSplit.isBinlogSplit()) {
Expand All @@ -154,12 +155,17 @@ protected void onSplitFinished(Map<String, MySqlSplitState> finishedSplitIds) {
mySqlSourceReaderContext.resetStopBinlogSplitReader();
suspendedBinlogSplit = toSuspendedBinlogSplit(mySqlSplit.asBinlogSplit());
context.sendSourceEventToCoordinator(new SuspendBinlogReaderAckEvent());
// do not request next split when the reader is suspended, the suspended reader will
// automatically request the next split after it has been wakeup
requestNextSplit = false;
} else {
finishedUnackedSplits.put(mySqlSplit.splitId(), mySqlSplit.asSnapshotSplit());
}
}
reportFinishedSnapshotSplitsIfNeed();
context.sendSplitRequest();
if (requestNextSplit) {
context.sendSplitRequest();
}
}

@Override
Expand Down