[oracle]#1244 Oracle URL format is inconsistent with the debezium def…

[yanghuaiGit]

flinkcdc oracle connector just support sid,but debezium default support serviceName,so we should set property 'database.url'

[leonardBang]

Thanks @yanghuaiGit for the contribution, the pr looks generally good,I left some comments.

[leonardBang]

Thanks @yanghuaiGit for the update, the change is in good shape, I only left two minor suggestions. I think we can merge this PR once you addressed them.

[modoojunko]

I have same problem to support SID and SERVICENAME to connect ORACLE.

Why don't we add one "type" way ?
getProperty("datebase.type")

if (type == "sid"){ return DriverManager.getConnection( "jdbc:oracle:thin@"+hostname+":"+port+":"+dbname,userName,userpwd )else if(type == "servicename"){ "jdbc:oracle:thin@"+hostname+":"+port+"/"+dbname,userName,userpwd }; }

[yanghuaiGit]

Usually the URL username password parameter is needed to connect to a data source, so you should expose the URL parameter to the customer rather than using a type parameter to control the generated URL format

[leonardBang]

@modoojunko please open another issue or discussion, we should not discuss unrelated issue the under this PR.

[leonardBang]

Thank @yanghuaiGit for the nice work, I only left one doc comment

[leonardBang]

Thanks @yanghuaiGit for the contribution, LGTM