Skip to content

Conversation

yanghuaiGit
Copy link
Contributor

flinkcdc oracle connector just support sid,but debezium default support serviceName,so we should set property 'database.url'

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanghuaiGit for the contribution, the pr looks generally good,I left some comments.

@yanghuaiGit yanghuaiGit force-pushed the oracle-properties-defaultUrl branch 2 times, most recently from 6bb2304 to c50634d Compare June 20, 2022 11:32
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanghuaiGit for the update, the change is in good shape, I only left two minor suggestions. I think we can merge this PR once you addressed them.

@modoojunko
Copy link

I have same problem to support SID and SERVICENAME to connect ORACLE.

Why don't we add one "type" way ?
getProperty("datebase.type")

if (type == "sid"){ return DriverManager.getConnection( "jdbc:oracle:thin@"+hostname+":"+port+":"+dbname,userName,userpwd )else if(type == "servicename"){ "jdbc:oracle:thin@"+hostname+":"+port+"/"+dbname,userName,userpwd }; }

@yanghuaiGit
Copy link
Contributor Author

Usually the URL username password parameter is needed to connect to a data source, so you should expose the URL parameter to the customer rather than using a type parameter to control the generated URL format

@leonardBang
Copy link
Contributor

@modoojunko please open another issue or discussion, we should not discuss unrelated issue the under this PR.

@apache apache deleted a comment from modoojunko Jun 23, 2022
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @yanghuaiGit for the nice work, I only left one doc comment

@leonardBang leonardBang force-pushed the oracle-properties-defaultUrl branch from 7de1587 to d323bf6 Compare August 9, 2022 04:20
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanghuaiGit for the contribution, LGTM

leonardBang pushed a commit that referenced this pull request Aug 9, 2022
@leonardBang leonardBang added this to the V2.3.0 milestone Aug 9, 2022
@leonardBang leonardBang closed this Aug 9, 2022
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants