Skip to content

Conversation

whhe
Copy link
Member

@whhe whhe commented Jul 27, 2022

fix #1416

@whhe
Copy link
Member Author

whhe commented Jul 27, 2022

There are some errors in mysql connector tests which are related to #1284 and apache/flink@bf55428, other failures have not been located and I think we can fix them in other PRs.

@leonardBang @Jiabao-Sun @GOODBOY008 PTAL.

@leonardBang leonardBang self-requested a review July 28, 2022 01:43
@ruanhang1993
Copy link
Contributor

@whhe Thanks for your PR.
It seems that this PR forces usage of the JUnit 4.7 provider. Maybe this change is enough to fix the problem by now.
But Flink is promoting the Junit 5 migration in FLINK-25325. I think we should use the JUnit 5 platform as well.

The problem may lie in the conflict in the dependency. And I find the junit version conflict.
截屏2022-07-28 下午3 58 52

@whhe
Copy link
Member Author

whhe commented Jul 28, 2022

@whhe Thanks for your PR. It seems that this PR forces usage of the JUnit 4.7 provider. Maybe this change is enough to fix the problem by now. But Flink is promoting the Junit 5 migration in FLINK-25325. I think we should use the JUnit 5 platform as well.

The problem may lie in the conflict in the dependency. And I find the junit version conflict. 截屏2022-07-28 下午3 58 52

Yes, JUnit provider is forced to be 4.7+ in this PR. I found that the tests of master branch were launched by junit-platform, while the JUnit version of Flink 1.14 was 4.13, which means there is something wrong in provider selection.

If we specify the JUnit provider here, we can also remove it or update to junit-platform when the Flink test utils used in Flink CDC is updated in the future.

@whhe
Copy link
Member Author

whhe commented Aug 4, 2022

#1446 would be able to resolve errors in mysql connector tests.

@ruanhang1993
Copy link
Contributor

ruanhang1993 commented Aug 4, 2022

It seems like the testMetadataColumns in many connector's xxxConenctorITCase fails. I will take a look at this.

@ruanhang1993
Copy link
Contributor

ruanhang1993 commented Aug 5, 2022

It seems like the testMetadataColumns in many connector's xxxConenctorITCase fails. I will take a look at this.

Because of this change in Flink(https://issues.apache.org/jira/browse/FLINK-20370), we need to add records whose type is update before when the primary keys of source and sink are different.

I will raise another PR to fix these tests.

@ruanhang1993
Copy link
Contributor

#1451 would be able to resolve errors in testMetadataColumns tests.

@leonardBang
Copy link
Contributor

Thanks @whhe @ruanhang1993 for the great work, but there's a failed test PolardbxSourceITCase, could you take a more look?

@whhe
Copy link
Member Author

whhe commented Aug 9, 2022

Thanks @whhe @ruanhang1993 for the great work, but there's a failed test PolardbxSourceITCase, could you take a more look?

Will have a try tomorrow, as today is the last day of my vacation.

@ruanhang1993
Copy link
Contributor

Thanks @whhe @ruanhang1993 for the great work, but there's a failed test PolardbxSourceITCase, could you take a more look?

I found that this test will sometimes throw an exception like this and the sqls in initializePolardbxTables will not be executed.
截屏2022-08-09 下午3 34 15

If the previous error does not occur, the container may exit with a warning after a few time: [Warning] [MY-011245] [Server] Plugin mysqlx reported: 'Galaxy session 0x7f970000b850 sid 43 kill pool 0x7f9700011a08.'. And some test cases will fail because of the exiting of the polarxdb container.

I have not found the reason why this happens.

@leonardBang
Copy link
Contributor

The test passed in my local env and the azure CI env after I upgrade the polardb-x docker image version, I doubt this issue is related to the docker image version instead of our codebase, I'll merge this pr now.

Thanks @whhe and @ruanhang1993 for the great work.

@leonardBang leonardBang closed this Aug 9, 2022
@leonardBang leonardBang added this to the V2.3.0 milestone Aug 9, 2022
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] integrated tests are skipped in some connectors
3 participants