-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[test] specify surefire provider #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are some errors in mysql connector tests which are related to #1284 and apache/flink@bf55428, other failures have not been located and I think we can fix them in other PRs. |
@whhe Thanks for your PR. The problem may lie in the conflict in the dependency. And I find the junit version conflict. |
Yes, JUnit provider is forced to be 4.7+ in this PR. I found that the tests of master branch were launched by If we specify the JUnit provider here, we can also remove it or update to |
#1446 would be able to resolve errors in mysql connector tests. |
It seems like the |
Because of this change in Flink(https://issues.apache.org/jira/browse/FLINK-20370), we need to add records whose type is update before when the primary keys of source and sink are different. I will raise another PR to fix these tests. |
#1451 would be able to resolve errors in |
Thanks @whhe @ruanhang1993 for the great work, but there's a failed test |
Will have a try tomorrow, as today is the last day of my vacation. |
I found that this test will sometimes throw an exception like this and the sqls in If the previous error does not occur, the container may exit with a warning after a few time: I have not found the reason why this happens. |
The test passed in my local env and the azure CI env after I upgrade the polardb-x docker image version, I doubt this issue is related to the docker image version instead of our codebase, I'll merge this pr now. Thanks @whhe and @ruanhang1993 for the great work. |
fix #1416