Skip to content

[cdc-connector][sqlserver] Fix SqlServerTableSource params order error #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

[cdc-connector][sqlserver] Fix SqlServerTableSource params order error #2847

merged 1 commit into from
Dec 11, 2023

Conversation

gong
Copy link
Contributor

@gong gong commented Dec 10, 2023

Prepare a Pull Request

Motivation

  • Fix SqlServerTableSource params order error

Modifications

  • change connectMaxRetries and connectionPoolSize order

@gong
Copy link
Contributor Author

gong commented Dec 10, 2023

@leonardBang @GOODBOY008 PTAL

joyCurry30
joyCurry30 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@joyCurry30 joyCurry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! LGTM.

GOODBOY008
GOODBOY008 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @gong , LGTM

@GOODBOY008 GOODBOY008 merged commit 08d6b81 into apache:master Dec 11, 2023
lvyanquan pushed a commit that referenced this pull request Jan 18, 2024
@gong @lvyanquan
[cdc-connector][sqlserver] Fix SqlServerTableSource params order error (
fac52dc 
#2847)

(cherry picked from commit 08d6b81)
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@gong
[cdc-connector][sqlserver] Fix SqlServerTableSource params order error (
3a6eacb 
apache#2847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

+1 more reviewer

@joyCurry30 joyCurry30 joyCurry30 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
sqlserver-cdc-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [sqlserver] connectMaxRetries and connectionPoolSize params order is reversed
3 participants
@gong @GOODBOY008 @joyCurry30