Skip to content

[issue-314] Support MySQL 5.6 #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2022
Merged

[issue-314] Support MySQL 5.6 #396

merged 2 commits into from
Jan 13, 2022

Conversation

xiangtao
Copy link
Contributor

@xiangtao xiangtao commented Sep 5, 2021 •
edited
Loading

  1. Add a MySqlMutiVersionTestBase class to support mysql multi-version container through parameterized test
  2. Update MySqlParallelSourceTestBase to support mysql multi-version
  3. Update all test case to support mysql 5.6 and 5.7 test
  4. Add gtid enable test for all test case

relation: https://github.com/ververica/flink-cdc-connectors/issues/314

@xiangtao xiangtao changed the title Add support mysql 5.6 test and update all test case to support mysql 5.6 and 5.7 [issue-314] Add support mysql 5.6 test and update all test case to support mysql 5.6 and 5.7 Sep 5, 2021
@leonardBang leonardBang self-requested a review September 6, 2021 17:19
@xiangtao
Copy link
Contributor Author

xiangtao commented Sep 7, 2021

Hi, @leonardBang
Do you have any suggestions?

@gtk96 gtk96 mentioned this pull request Nov 15, 2021
Closed
@yandavid163
Copy link

翘首以盼5.6

@which520
Copy link

which520 commented Dec 9, 2021

强烈期待5.6,我都开发完了，才知道不支持我们现有得生产mysql版本

@leonardBang leonardBang added this to the V2.2.0 milestone Dec 17, 2021
@leonardBang leonardBang linked an issue Jan 5, 2022 that may be closed by this pull request
[Feature] Flink-CDC supports MySQL 5.6 version #314
Closed
@leonardBang
Copy link
Contributor

@xiangtao Could you rebase this PR to master ? I checked the difference between MySQL 5.6 and MySQL 5.7, the main usage of our code should be same.

@smallx
Copy link

smallx commented Jan 12, 2022

We need you @xiangtao :)

leonardBang
leonardBang approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiangtao for the contribution, LGTM, I also append a commit to help improve this PR

@leonardBang leonardBang changed the title [issue-314] Add support mysql 5.6 test and update all test case to support mysql 5.6 and 5.7 [issue-314] Support MySQL 5.6 Jan 13, 2022
@leonardBang leonardBang merged commit c584ecf into apache:master Jan 13, 2022
rookie202010 pushed a commit to rookie202010/flink-cdc-connectors that referenced this pull request Jan 20, 2022
@xiangtao @leonardBang
[mysql] Support MySQL 5.6 (apache#396)
3dfbecb 
Co-authored-by: Leonard Xu <[email protected]>
@leonardBang leonardBang mentioned this pull request Mar 16, 2022
Merged
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@xiangtao @leonardBang
[mysql] Support MySQL 5.6 (apache#396)
3c805b0 
Co-authored-by: Leonard Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2.2.0
Development

Successfully merging this pull request may close these issues.

[Feature] Flink-CDC supports MySQL 5.6 version
5 participants
@xiangtao @yandavid163 @which520 @leonardBang @smallx