-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for copy.existing.namespace.regex and pipeline config to mongo-cdc #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for copy.existing.namespace.regex and pipeline config to mongo-cdc #475
Conversation
Thanks @bobby-richard for the contribution, @Jiabao-Sun Could you help review this PR? |
@leonardBang OK |
Thanks @bobby-richard, It's a nice improvement. This setting was not exposed before because multiple databases and collections are complicated for users. The If we need to improve the support of multiple databases and collections, I think we should also expose |
Sounds good @Jiabao-Sun, I will expose |
@Jiabao-Sun Exposed pipeline configuration as well. Nice catch! |
Thanks @bobby-richard, it LGTM. |
@leonardBang @Jiabao-Sun any updates? |
Thanks @bobby-richard, it's a good enhencement that we can subscribe and filter multiple databases and collections. @wuchong @leonardBang Do you have any suggestions? |
@@ -206,6 +213,13 @@ Connector Options | |||
only documents in which the closed field is set to false are copied. | |||
</td> | |||
</tr> | |||
<tr> | |||
<td>copy.existing.namespace.regex</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jiabao-Sun for the contribution, could we use databaselist
and collectionList
filter and then transfer to underlying copy.existing.namespace.regex
here for unification consideration? other parts looks good to me.
closed #940 |
Problem: I need to capture data from multiple tenant databases in the same mongodb cluster
The connector already allowed you to capture data from multiple databases/collections, but this was not very useful without the ability to filter. The copy.existing.namespace.regex setting already exists in the kafka source connector and does exactly this. So this PR just exposes the existing setting to the flink connector.