Skip to content

Conversation

luoyuxia
Copy link
Contributor

No description provided.

@luoyuxia luoyuxia changed the title support to read tables of inconsistent schema #487 support to read tables of inconsistent schema Oct 11, 2021
@luoyuxia
Copy link
Contributor Author

@leonardBang

@leonardBang leonardBang self-requested a review October 11, 2021 10:29
@luoyuxia luoyuxia force-pushed the allow-schema-mismatch branch from 6591a34 to e486a30 Compare October 11, 2021 10:41
Comment on lines 677 to 685
new String[] {
"+I[111, user_111, Shanghai, 123567891234, [email protected]]",
"+I[121, user_121, Shanghai, 123567891234, null]",
"+I[211, user_211, Shanghai, 123567891234, null]",
"+I[221, user_221, Shanghai, 123567891234, [email protected]]",
"-U[111, user_111, Shanghai, 123567891234, [email protected]]",
"+U[111, user_111, Shanghai, 123567891234, [email protected]]",
"-U[211, user_211, Shanghai, 123567891234, null]",
"+U[211, user_211, HangZhou, 123567891234, null]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can order the records for better understanding, because we call assertEqualsInAnyOrder later

Comment on lines 692 to 698
// should drop the userDatabase1 and userDatabase2
for (UniqueDatabase database : new UniqueDatabase[]{userDatabase1, userDatabase2}) {
try (Connection connection = database.getJdbcConnection();
Statement statement = connection.createStatement()) {
statement.execute("drop database " + database.getDatabaseName());
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

name VARCHAR(255) NOT NULL DEFAULT 'flink',
address VARCHAR(1024),
phone_number VARCHAR(512),
email VARCHAR(255)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use another field name which is different with the table in database1?

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luoyuxia for the update, LGTM once the build pass

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 64fc3e3 into apache:master Oct 12, 2021
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants