Skip to content

Conversation

YesOrNo828
Copy link
Contributor

@YesOrNo828 YesOrNo828 commented Nov 25, 2021

address wrong calss type in class comments(MysqlSource, MysqlSourceBuilder).
Should be MySqlSource.<String>builder(), but now MySqlSource.<RowData>builder().
#650

@YesOrNo828
Copy link
Contributor Author

@leonardBang Can you review this, when you are not busy? Thanks.

@leonardBang leonardBang self-requested a review December 1, 2021 03:33
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YesOrNo828 for the contribution, LGTM

@leonardBang leonardBang merged commit 7712f98 into apache:master Dec 1, 2021
leonardBang pushed a commit to leonardBang/flink-cdc-connectors that referenced this pull request Dec 16, 2021
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]address wrong class type in MysqlSource and MysqlSourceBuilder comments
2 participants