Skip to content

Conversation

luoyuxia
Copy link
Contributor

…us with GeometryCollection for mysql8

This pr add an extra test method testMySql8AllDataTypes to cover the GeomCollection data type.

ST_GeomFromText('MULTIPOINT((1 1),(2 2))'),
ST_GeomFromText('MultiLineString((1 1,2 2,3 3),(4 4,5 5))'),
ST_GeomFromText('MULTIPOLYGON(((0 0, 10 0, 10 10, 0 10, 0 0)), ((5 5, 7 5, 7 7, 5 7, 5 5)))'),
ST_GeomFromText('GEOMETRYCOLLECTION(POINT(10 10), POINT(30 30), LINESTRING(15 15, 20 20))')
Copy link
Contributor Author

@luoyuxia luoyuxia Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although GEOMCOLLECTION is synonymous with GEOMETRYCOLLECTION in mysql8.0, but it still needs to use GEOMETRYCOLLECTION when insert such data, otherwise it'll throw invalid gis data exception.

@@ -36,7 +36,7 @@ skip-host-cache
skip-name-resolve
#datadir=/var/lib/mysql
#socket=/var/lib/mysql/mysql.sock
#secure-file-priv=/var/lib/mysql-files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/lib/mysql-files doesn't exist in mysql8.0, so change it to /var/lib/mysql

@luoyuxia luoyuxia force-pushed the cover_geomcollection_for_mysql8 branch 2 times, most recently from 0668eab to eace2b1 Compare January 21, 2022 10:01
@luoyuxia luoyuxia force-pushed the cover_geomcollection_for_mysql8 branch from eace2b1 to 3f42c47 Compare January 21, 2022 10:05
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 5511904 into apache:master Jan 21, 2022
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants