Skip to content

Conversation

leonardBang
Copy link
Contributor

[task] Remove changelog json format support #901

@leonardBang leonardBang added this to the V2.2.0 milestone Mar 4, 2022
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @leonardBang !

I made a global search with keyword "changelog-json" and found some remnants in about.md :

https://github.com/ververica/flink-cdc-connectors/blob/c77275cb683bdb7aa13f4d6b89baecf9e382a305/docs/content/about.md?plain=1#L22

And the link incorrectly points to an empty page in GitHub wiki. I think we can add a footnote here suggesting changelog-json is deprecated, and fix the broken link.

@leonardBang
Copy link
Contributor Author

And the link incorrectly points to an empty page in GitHub wiki. I think we can add a footnote here suggesting changelog-json is deprecated, and fix the broken link.

Nice catch, I decide to delete the piece as they're rarely used( if users use it they have found the link error).

@leonardBang leonardBang force-pushed the remove_changelog-json branch from 9970a0b to 6de2e75 Compare March 7, 2022 09:18
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @leonardBang ! LGTM.

@leonardBang leonardBang merged commit 3f26906 into apache:master Mar 7, 2022
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants