-
Notifications
You must be signed in to change notification settings - Fork 158
Closed
Labels
migrated-from-old-repoMigrated from old repositoryMigrated from old repository
Description
Issue by skrawcz
Thursday Dec 23, 2021 at 02:10 GMT
Originally opened as stitchfix/hamilton#32
Goal of this PR is to provide more extensive examples.
Inspiration is from:
https://github.com/Netflix/metaflow/blob/master/metaflow/tutorials/01-playlist/playlist.py
Two interesting things to note here:
- We could have the driver do the loading of the CSV, or we could have a function to do it.
- Filter operations are easiest to happen in the driver I think. Not to say you can't do it,
we'd just need better logic around creating the dataframe, and not trying to combine series
with various index lengths. Hmm.
Additions
- Examples
Removals
- N/A
Changes
- N/A
Testing
- The example works. Tested locally.
Todos
- [] add more examples and see if this makes sense.
Checklist
- PR has an informative and human-readable title
- Changes are limited to a single goal (no scope creep)
- Code can be automatically merged (no conflicts)
- Code follows the standards laid out in the dev standards.
- Passes all existing automated tests
- Any change in functionality is tested
- New functions are documented (with a description, list of inputs, and expected output)
- Placeholder code is flagged / future todos are captured in comments
- Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
- Reviewers requested with the Reviewers tool ➡️
Testing checklist
Python
- python 3.6
- python 3.7
skrawcz included the following code: https://github.com/stitchfix/hamilton/pull/32/commits
Metadata
Metadata
Assignees
Labels
migrated-from-old-repoMigrated from old repositoryMigrated from old repository