feat: set snapshot summary property in append action #1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
May 28, 2025
| @@ -3712,7 +3712,7 @@ dependencies = [ | |||
| "iceberg-catalog-rest", | |||
| "iceberg-datafusion", | |||
| "iceberg_test_utils", | |||
| "ordered-float 4.6.0", | |||
| "ordered-float 2.10.1", | |||
There was a problem hiding this comment.
I didn't make the change, cargo test did
Xuanwo
approved these changes
May 29, 2025
liurenjie1024
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR tries to do the same thing as reverted PR, which adds capability to set snapshot summary properties.
Followup on thread: #1336 (comment), in this PR I took a different way, which expose interfaces within fast append action.
Are these changes tested?
Yes, I add new unit tests.