Skip to content

Conversation

e-mhui
Copy link
Contributor

@e-mhui e-mhui commented Jun 14, 2023

Prepare a Pull Request

[INLONG-8175][Sort] MySQL CDC support read data from specific timestamp / earliest offset / specific offset

Motivation

MySQL CDC support read data from specific timestamp / earliest offset / specific offset.

Ref:

  1. [mysql] Support starting reading binlog from earliest offset / specific offset / timestamp flink-cdc#1661
  2. [mysql] Use event filter to drop events earlier than the specified timestamp in timestamp startup mode flink-cdc#1724

Modifications

  1. MySQL CDC support read data from specific timestamp / earliest offset / specific offset.
  2. Add the error message under the case that starting from earliest offset but schema change happened before.

Verifying this change

Run MySqlLoadSqlParseTest.testMySqlLoadStartupFromSpecificTimestampSqlParse(), MySqlLoadSqlParseTest.testMySqlLoadStartupFromSpecificBinlogSqlParse() and MySqlLoadSqlParseTest.testMySqlLoadStartupFromSpecificGtidSqlParse().

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

You can see the document in this PR (apache/inlong-website#775).

@dockerzhang
Copy link
Contributor

@e-mhui please update the document at the same time, thanks.

@e-mhui
Copy link
Contributor Author

e-mhui commented Jun 15, 2023

@e-mhui please update the document at the same time, thanks.

Done.

@EMsnap
Copy link
Member

EMsnap commented Jun 16, 2023

could u add a test for the feature ?

@e-mhui
Copy link
Contributor Author

e-mhui commented Jun 16, 2023

could u add a test for the feature ?

Done.

Copy link
Member

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your contribution, BTW I'll attach your doc update here apache/inlong-website#775 for reminder

@dockerzhang dockerzhang merged commit 9c56a7a into apache:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] MySQL CDC support read data from specific timestamp
5 participants