Skip to content

MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols #20466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols #20466

wants to merge 3 commits into from
+13 −7

Conversation

elmoctarebnou
Copy link

@elmoctarebnou elmoctarebnou commented Sep 3, 2025 •
edited by github-actions bot
Loading

Cleanup 'share' from group.coordinator.rebalance.protocols as a valid
value. Share Groups should instead be enabled through the share.version
Reviewers: Christo
Lolov[email protected]

@elmoctarebnou
Cleanup 'share' from group.coordinator.rebalance.protocols as a valid…
88834ca 
… value. Share Groups should instead be enabled through the share.version
@github-actions github-actions bot added triage PRs from the community core Kafka Broker clients small Small PRs labels Sep 3, 2025
@elmoctarebnou elmoctarebnou mentioned this pull request Sep 3, 2025
Open
AndrewJSchofield
AndrewJSchofield requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

.gitignore Outdated
@@ -31,6 +31,8 @@ TAGS
Vagrantfile.local
/logs
.DS_Store
.bloop/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @AndrewJSchofield. I’ve reverted the .gitignore change. Please let me know if there’s anything else I should adjust.

@AndrewJSchofield AndrewJSchofield added KIP-932 Queues for Kafka ci-approved and removed triage PRs from the community labels Sep 3, 2025
@AndrewJSchofield AndrewJSchofield changed the title Cleanup 'share' from group.coordinator.rebalance.protocols MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols Sep 3, 2025
@github-actions github-actions bot added the tests Test fixes (including flaky tests) label Sep 3, 2025
@AndrewJSchofield
Copy link
Member

@elmoctarebnou There are some build failures. Please check the logs and resolve. For example:

Error:  /home/runner/work/kafka/kafka/core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:1789:9: local var config in method testGroupCoordinatorRebalanceProtocols is never updated: consider using immutable val

@elmoctarebnou
Copy link
Author

Thanks, @AndrewJSchofield — I fixed the error you pointed out. I also chatted with @clolov , and he suggested adding a small test to validate that "share" is not included in group.coordinator.rebalance.protocols, which I’ve now added.

@elmoctarebnou
Copy link
Author

Hi @AndrewJSchofield all tests are passing except for the ones already marked as flaky, which seem unrelated to this change.

JimmyWang6
JimmyWang6 reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@JimmyWang6 JimmyWang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
@@ -1784,15 +1784,15 @@ class KafkaConfigTest {
props.put(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, "consumer")
assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra blank.

group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
@@ -69,6 +69,11 @@ public class GroupCoordinatorConfig {
Group.GroupType.CLASSIC.toString(),
Group.GroupType.CONSUMER.toString(),
Group.GroupType.STREAMS.toString());
public static final List<String> GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED = List.of(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could reuse the GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT constant since they are exactly the same.

@AndrewJSchofield
Copy link
Member

Requesting review from @dajac since he's most knowledgeable about this config. I'm not certain the change is necessary or worthwhile given that this config is possibly being deprecated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewJSchofield AndrewJSchofield AndrewJSchofield requested changes

@dajac dajac Awaiting requested review from dajac

+1 more reviewer

@JimmyWang6 JimmyWang6 JimmyWang6 left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci-approved clients core Kafka Broker group-coordinator KIP-932 Queues for Kafka small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmoctarebnou @AndrewJSchofield @JimmyWang6