[MSCMPUB-59] Use interactive mode for SCM when Maven is executed in interactive mode

[jira-importer]

Konrad Windszus opened MSCMPUB-59 and commented

When Maven is executed in interactive mode (i.e. batch mode is not enabled via -B) the underlying SCM commands should also be executed in interactive mode.
That way asking for credentials is possible.
Currently with m-scm-publish-p 3.1.0 I see the following

[INFO] --- scm-publish:3.1.0:publish-scm (scm-publish) @ jackrabbit-site ---
[INFO] Checking out the pub tree from scm:svn:https://svn.apache.org/repos/asf/jackrabbit/site/live/jcr into /Users/konradwindszus/svn/jackrabbit/site/trunk/target/scmpublish-checkout
[INFO] Executing: /bin/sh -c cd /Users/konradwindszus/svn/jackrabbit/site/trunk/target && svn --non-interactive checkout https://svn.apache.org/repos/asf/jackrabbit/site/live/jcr@ /Users/konradwindszus/svn/jackrabbit/site/trunk/target/scmpublish-checkout
[INFO] Updating checkout directory with actual content in /Users/konradwindszus/svn/jackrabbit/site/trunk/target/site
[INFO] Content consists of 10 directories and 190 files = 4 MB
[INFO] Publishing content to SCM will result in 0 addition(s), 190 update(s), 1 delete(s)
.....
[INFO] Executing: /bin/sh -c cd /Users/konradwindszus/svn/jackrabbit/site/trunk/target/scmpublish-checkout && svn remove --targets /var/folders/f8/_3c0rvgd00n324sqjc8y_3wr0000gn/T/maven-scm-8456434031716391901-targets
[INFO] Checking in SCM, starting at Wed Jul 19 15:35:21 CEST 2023...
[INFO] Executing: /bin/sh -c cd /Users/konradwindszus/svn/jackrabbit/site/trunk/target/scmpublish-checkout && svn --non-interactive commit --file /var/folders/f8/_3c0rvgd00n324sqjc8y_3wr0000gn/T/maven-scm-1361910343.commit --encoding UTF-8
[ERROR] Failed to check-in files to SCM: The svn command failed. svn: E215004: Authentication failed and interactive prompting is disabled; see the --force-interactive option
svn: E215004: Commit failed (details follow):
svn: E215004: No more credentials or we tried too many times.
Authentication failed

---

Affects: 3.1.0

Issue Links:

• SCM-1011 Do not set --non-interactive for SVN provider by default
  ("is blocked by")
• MRELEASE-1091 Use non-interactive (batch) mode for forked Maven process

[jira-importer]

Konrad Windszus commented

sjaranowski Do you know if https://issues.apache.org/jira/browse/MSHARED-1072 is the culprit here as well?

[jira-importer]

Konrad Windszus commented

The flag passed to the release descriptor in

maven-scm-publish-plugin/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java

Line 323 in a42ba9a

descriptorBuilder.setInteractive(settings.isInteractiveMode());

is not used when calling AbstractScmPublishMojo.checkoutExisting() which internally uses https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java#L115

[jira-importer]

Slawomir Jaranowski commented

I see that plexus-utils is used here ... we have duplicate classes cli.* in both library maven-shared-utils and plexu-utils ...
I have only fixed a maven-shared-utils

[jira-importer]

Michael Osipov commented

Guys, is this addressed?

[jira-importer]

Konrad Windszus commented

No, this is blocked by https://issues.apache.org/jira/browse/SCM-1011 which requires codehaus-plexus/plexus-utils#260. However a review of the draft PR at apache/maven-scm#181 would be appreciated.

[jira-importer]

Michael Osipov commented

Will have a look next couple of days.