[MNG-5729] Measure (build time) durations with System.nanoTime only

[jira-importer]

Michael Osipov opened MNG-5729 and commented

Currently, we solely rely on System.currentTimeMillis to track start/end times as well as durations. This is error prone and not guaranteed to deliver a monotic value with positive durations.

We should consider employing System.nanoTime throughout the core where the above mentioned conditions are met. E.g., in some of:

maven-aether-provider/src/test/java/org/apache/maven/repository/internal/util/ConsoleTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java: this.transferStartTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java: long buildEndTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java: long buildStartTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java: long buildEndTime = System.currentTimeMillis();
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: long finish = System.currentTimeMillis();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
DefaultMaven.java: request.setStartTime( new Date() ); 
DefaultMavenExecutionRequest.java: public Date getStartTime() 
DefaultMavenExecutionRequest.java: projectBuildingRequest.setBuildStartTime( getStartTime() ); 
MavenExecutionRequest.java: Date getStartTime(); 
MavenSession.java: public Date getStartTime() 
MavenSession.java: return request.getStartTime(); 
ExecutionEventLogger.java: long time = finish - session.getRequest().getStartTime().getTime(); 

and all other code spots where Date or long is used.

---

Affects: 3.2.3

Issue Links:

• MRESOLVER-14 Statistics should be calculated using System.nanoTime() instead of System.currentTimeMillis()
  ("is blocked by")
• MRESOLVER-635 Use Instant instead of untyped millis for TransferResource startTime
  ("requires")
• MNG-5626 Avoid negative durations or handle them correctly
  ("is depended upon by")

Remote Links:

• GitHub Pull Request #1965
  
• GitHub Pull Request #1969
  
• GitHub Pull Request #1972
  

Backported to: 4.0.0-rc-2

1 votes, 5 watchers

[jira-importer]

Michael Osipov commented

gnodet, is this something worth looking into for 4.x or close out? Also note the depending issue.

[jira-importer]

Guillaume Nodet commented

Some of those require a resolver change (in particular the TransferResource.getTransferStartTime().
Some are used internally and could be changed easily.
I would not touch the ones on MavenSession / MavenExecutionRequest, the Maven 4 API uses better objects:

maven/api/maven-api-core/src/main/java/org/apache/maven/api/ProtoSession.java

Line 67 in fcd9c0f

Instant getStartTime();