[MNG-7344] Effective pom should contain more finegrained details regarding its content origin: track dependencyManagement import

[jira-importer]

Robert Scholte opened MNG-7344 and commented

To support MPH-183 some changes needs to be done in Maven Core.

For every element that is not part of the raw model, it must be possible to get the "resolution path" to that element.
Until now, only the usual pure inheritance is tracked though InputLocation, as done in MNG-1803, later displayed by verbose help effective-pom with MPH-160

The following are known to add elements to the effective pom:

• BOMs dependencyManagement import
• Tiles Maven Plugin by Mark Derricutt

Without this feature, it is very hard to detect where these extra elements are coming from.

---

Attachments:

• MicrosoftTeams-image.png (35.41 kB)

Issue Links:

• MNG-8004 Enhance location tracking
  ("is duplicated by")

• MNG-7906 Dependency Management import (BOM) does not work the "maven way"

• MPH-183 Effective-pom + verbose should show import path to BOM dependencyManagement
  ("is required by")

• MNG-1803 Provide line number information when there are errors processing a pom.xml
  ("supercedes")

Remote Links:

• GitHub Pull Request #333
  
• GitHub Pull Request #603
  

Backported to: 4.0.0-beta-4

1 votes, 4 watchers

[jira-importer]

Maarten Mulders commented

Situation:

!MicrosoftTeams-image.png!

Thoughts so far

1. We need a place in the Modello generated classes to keep track of "why we loaded this model". Let's call it "referencing model"; it's a variable of type InputLocation. This requires a change in Modello
2. When we merge the model of an "intermediary" BOM ("bom-a" or "bom-b", respectively), we make a copy of the elements that we take from BOM C and overwrite in bom-a or bom-b, but we add the referencingModel (which is "bom-a" or "bom-b", respectively) to the copy. This requires a change in our own "Model Merger" classes.
3. When we want to know the resolution path of a particular element in the effective model, we can follow back the referencingModel to find the path from "pom" to "bom-c", including the route that we took (either over "bom-a" or "bom-b"). This requires a change in the Maven Help Plugin (MPH-183).

[jira-importer]

Guillaume Nodet commented

This looks much more easy to implement in 4.x with the velocity templates that are used to generate the model and parsers.

[jira-importer]

Maarten Mulders commented

gnodet agreed. I don't think backporting to Maven 3.x is worth the effort, seeing how much work has been necessary to get this to a working point.