[MNG-5668] Execute after:* phases when build fails #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA issue: [MNG-5668](https://issues.apache.org/jira/browse/MNG-5668) When a build step fails, Maven should still execute its corresponding after:* phases to ensure proper cleanup. This fix modifies the BuildPlanExecutor to: - Execute after:* phases when their corresponding before:* phase has been executed - Maintain proper phase ordering during failure handling - Handle cleanup phase failures gracefully without affecting the original error - Preserve concurrent build capabilities This ensures cleanup tasks (like resource cleanup or test environment teardown) are properly executed even when the build fails.
cstamas
approved these changes
Mar 27, 2025
|
Resolve #6656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-5668
When a build step fails, Maven should still execute its corresponding after:* phases to ensure proper cleanup. This fix modifies the BuildPlanExecutor to:
This ensures cleanup tasks (like resource cleanup or test environment teardown) are properly executed even when the build fails.