[MNG-8718] Restore Maven 3 compat: ProjectBuilder is unusable for legacy code #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven 3 codebase is not able to use ProjectBuilder in certain cases, even if it asks for resolver session from Maven itself. --- https://issues.apache.org/jira/browse/MNG-8718
cstamas
added a commit
to takari/takari-plugin-testing-project
that referenced
this pull request
May 1, 2025
Sadly, it needs Maven 4 change as well, so rc-3 works for ITs only, and maybe rc-4 will work UTs as well. Requires change in Maven Core: apache/maven#2285
cstamas
changed the title
gnodet
approved these changes
May 3, 2025
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
May 3, 2025
|
Resolve #9581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven 3 codebase is not able to use create new session, and use ProjectBuilder with it, even if it asks for resolver session from Maven itself.
https://issues.apache.org/jira/browse/MNG-8718