Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 28, 2025

No description provided.

@@ -402,8 +402,6 @@ static Session newSession(RepositorySystem system, Lookup lookup, @Nullable Loca
mavenUserHome.resolve("settings.xml"))
.getEffectiveSettings();

settings.getProfiles();
Copy link
Contributor

@Pankraz76 Pankraz76 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should find such issues by tooling.

image

mostly IO stuff easy to rewrite:
image

Copy link
Contributor

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1

@elharo elharo marked this pull request as ready for review May 28, 2025 14:20
@elharo elharo merged commit 4dfeeab into master May 28, 2025
26 checks passed
@elharo elharo deleted the profiles branch May 28, 2025 14:20
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants