Skip to content

Unfurl CLI #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

Unfurl CLI #2465

merged 2 commits into from
Jun 11, 2025

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 10, 2025 •
edited
Loading

Remove some heavy redundancies, simplify.

Changes:

  • layering is "private matter" of parser, no need to bring it up to BaseParser (mvn does it only)
  • CommonsCliOptions made non-abstract
  • interpolate reworked to be reusable instead of copy-pasta
  • and now that Options can "walk by themselves", we can bring it into context, and a cause of this is dropping several anemic classes

@cstamas
Unfurl CLI
72dc3c1 
Remove some heavy redundancies, simplify.
@cstamas cstamas requested a review from gnodet June 10, 2025 15:46
@cstamas cstamas self-assigned this Jun 10, 2025
@cstamas cstamas requested a review from slawekjaranowski June 10, 2025 18:58
@cstamas cstamas marked this pull request as ready for review June 10, 2025 20:08
elharo
elharo approved these changes Jun 11, 2025
View reviewed changes
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java
try {
parsedOptions = parseCliOptions(context);
context.options = parseCliOptions(context);
} catch (Exception e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in this PR, but this should be a more specific catch

@cstamas cstamas merged commit ddc228e into apache:master Jun 11, 2025
19 checks passed
@cstamas cstamas deleted the unfurl-cli branch June 11, 2025 13:14
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@gnodet gnodet Awaiting requested review from gnodet

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees

@cstamas cstamas

Labels
maintenance
Projects
None yet
Milestone
4.0.0-rc-4
Development

Successfully merging this pull request may close these issues.
2 participants
@cstamas @elharo