[SPARK-53546][TESTS][FOLLOW-UP] Fix nested array schema evolution and style for InMemoryBaseTable #52359
+25
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… style for InMemoryBaseTable
szehon-ho
commented
Sep 16, 2025
| } else { | ||
| extractArrayValue(arrayData, elementType, | ||
| readSchema.fields(readIndex).dataType) | ||
| val writeType = writeSchema.fields(writeIndex).dataType.asInstanceOf[ArrayType] |
There was a problem hiding this comment.
note: small bug here, updated the corresponding test
szehon-ho
commented
Sep 16, 2025
| } | ||
|
|
||
| // TODO- support schema evolution for missing nested types using UPDATE SET * and INSERT * | ||
| // currently the source struct needs to be fully compatible with target struct |
There was a problem hiding this comment.
Note: this is unrelated, but not sure we are going to do the TODO, so just downgrading it to a comment. It can be addressed it in #52347, but still debating whether it makes sense to do or not
|
cc @cloud-fan |
|
Thanks, the failure looks not related, re-running it |
cloud-fan
approved these changes
Sep 17, 2025
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix nested array struct schema evolution case for InMemoryDataSource, also style fixes.
Why are the changes needed?
Address style review comment (#52299 (comment)) and a small bug fix for #52299 (test-only)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran affected unit test
Was this patch authored or co-authored using generative AI tooling?
No