Skip to content

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Fix the intention of 'read parquet footers in parallel' test

Why are the changes needed?

The 'read parquet footers in parallel' test creates a json file as an invalid input for the parquet footer reader, skipping the hidden files like normal reads

Does this PR introduce any user-facing change?

no

How was this patch tested?

modified test

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Sep 19, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yaooqinn .

  1. Please fix the compilation failure due to the unused import statement.
[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala:22:30: Unused import
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=unused-imports, site=org.apache.spark.sql.execution.datasources.parquet
[error] import org.apache.hadoop.fs.{FileSystem, Path}
[error]        
  1. We need a JIRA issue for this test improvement because this is a logic change, not an indentation.
- val fileStatuses =
-   Seq(fs.listStatus(path1), fs.listStatus(path2), fs.listStatus(path3)).flatten
+ val fileStatuses = HadoopFSUtils.listFiles(
+   new Path(basePath),
+   hadoopConf,
+   (path: Path) => path.getName != "_SUCCESS").flatMap(_._2)

@yaooqinn yaooqinn changed the title [MINOR][TESTS] Fix the intention of 'read parquet footers in parallel' test [SPARK-53655][TESTS] Fix the intention of 'read parquet footers in parallel' test Sep 22, 2025
@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun for the suggested changes

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @yaooqinn .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-53655][TESTS] Fix the intention of 'read parquet footers in parallel' test [SPARK-53655][SQL][TESTS] Fix the intention of 'read parquet footers in parallel' test Sep 22, 2025
@yaooqinn yaooqinn deleted the footer branch September 23, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants