-
-
Notifications
You must be signed in to change notification settings - Fork 80
Support non-junit-binding testing server and junit5 extension. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
============================================
+ Coverage 68.25% 68.26% +0.01%
- Complexity 1178 1189 +11
============================================
Files 167 169 +2
Lines 5129 5156 +27
Branches 560 561 +1
============================================
+ Hits 3501 3520 +19
- Misses 1365 1370 +5
- Partials 263 266 +3
|
I have read the CLA Document and I hereby sign the CLA |
nobodyiam
reviewed
May 1, 2023
...ckserver-junit5/src/main/java/com/ctrip/framework/apollo/mockserver/MockApolloExtension.java
Outdated
Show resolved
Hide resolved
...erver-junit5/src/test/java/com/ctrip/framework/apollo/mockserver/ExtensionLifecycleTest.java
Outdated
Show resolved
Hide resolved
nobodyiam
approved these changes
May 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Introduce a standalone(non-junit4-binded) testing server and junit5 testing server extension.
Which issue(s) this PR fixes:
Fixes #
Brief changelog
Extract testing server implementation to ApolloTestingServer.
Add a new module for junit5 extension.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.