Skip to content

Conversation

vyag
Copy link
Contributor

@vyag vyag commented Apr 29, 2023

What's the purpose of this PR

Introduce a standalone(non-junit4-binded) testing server and junit5 testing server extension.

Which issue(s) this PR fixes:

Fixes #

Brief changelog

Extract testing server implementation to ApolloTestingServer.
Add a new module for junit5 extension.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #25 (74a74e9) into main (78ec538) will increase coverage by 0.01%.
The diff coverage is 89.32%.

@@             Coverage Diff              @@
##               main      #25      +/-   ##
============================================
+ Coverage     68.25%   68.26%   +0.01%     
- Complexity     1178     1189      +11     
============================================
  Files           167      169       +2     
  Lines          5129     5156      +27     
  Branches        560      561       +1     
============================================
+ Hits           3501     3520      +19     
- Misses         1365     1370       +5     
- Partials        263      266       +3     
Impacted Files Coverage Δ
...amework/apollo/mockserver/MockApolloExtension.java 77.77% <77.77%> (ø)
...ip/framework/apollo/mockserver/EmbeddedApollo.java 84.61% <83.33%> (-8.16%) ⬇️
...amework/apollo/mockserver/ApolloTestingServer.java 90.90% <90.90%> (ø)

... and 3 files with indirect coverage changes

@vyag
Copy link
Contributor Author

vyag commented Apr 29, 2023

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 38ff077 into apolloconfig:main May 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants