repair the application registerBeanDefinitions read not appropriate c… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration,cause apollo config wasn't the first configuration in environment during registerBeanDefinitions to postProcessBeanFactory,when spring.cloud.bootstrap.enabled is set to true
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
============================================
- Coverage 67.80% 67.78% -0.03%
Complexity 1163 1163
============================================
Files 164 165 +1
Lines 5104 5107 +3
Branches 557 559 +2
============================================
+ Hits 3461 3462 +1
- Misses 1375 1376 +1
- Partials 268 269 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Please also update the CHANGES.md |
I have modified,plz check it,thx |
nobodyiam
reviewed
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repair the application registerBeanDefinitions read not appropriate configuration
What's the purpose of this PR
repair the application registerBeanDefinitions read not appropriate configuration,cause apollo config wasn't the first configuration in environment during registerBeanDefinitions to postProcessBeanFactory,when spring.cloud.bootstrap.enabled is set to true
I have verified that this repair works in our project
For details, plz see the blog : http://t.csdn.cn/aI7Q1
Which issue(s) this PR fixes:
Fixes # no exists issue
Brief changelog
ApolloApplicationContextInitializer#initialize : When the context has been initialized,also want to add ensureBootstrapPropertyPrecedence processing