🐛 Bug Report: Presence of x-apprwite-warning header causes output corruption

[maglnet]

👟 Reproduction steps

We experienced an issue today:

When using Appwrite\Services\Databses->listDocuments the API returns an x-apprwite-warning header containing the following message: this route is deprecated. see the updated documentation for improved compatibility and migration details.

Because of this line, the warning is directly sent to the output stream and breaks other outputs:
https://github.com/appwrite/sdk-for-php/blob/main/src/Appwrite/Client.php#L265

👍 Expected behavior

The library should not output warnings directly to the output stream, but should us a logging mechanism.

👎 Actual Behavior

See above / Reproduction Steps.

🎲 Appwrite version

Version 0.10.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[maglnet]

Maybe the easiest fix, if the mentioned line would be replaced by a trigger_error like this:

trigger_error($warning, E_USER_WARNING);

[ChiragAgg5k]

@maglnet thanks for bringing this up! i really like the idea of using trigger_error($warning, E_USER_WARNING); instead of echo like we currently do. this keeps error handling much easier for end users and can be easily suppressed for users who dont want to see it.

would you like to work on it? its just a simple fix here - https://github.com/appwrite/sdk-generator/blob/8e8e39634ba7558704522959d88f3542563a5444/templates/php/src/Client.php.twig#L192

[maglnet]

Thanks for pointing me to the repo where code is maintained, i thought it was not possible to create a PR because this repo here is marked read only.

PR is now created.

Best regards
Matthias