Fix autocomplete for Databases.createDocument #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #76 Update `createDocument` method to improve TypeScript autocompletion. * **src/models.ts** - Remove the string index signature from `Models.Document`. - Add a new type `AnyDocument` extending `Models.Document` with the string index signature. * **src/services/databases.ts** - Update `createDocument` method to use `T extends Models.Document = Models.AnyDocument`. - Update `data` parameter type to `Omit<T, keyof Models.Document>`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/appwrite/sdk-for-web/issues/76?shareId=XXXX-XXXX-XXXX-XXXX).
|
This library is auto-generated by the Appwrite SDK Generator, and does not accept pull requests directly. To learn more about how you can help us improve this SDK, please check the contributing guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Update
createDocumentmethod to improve TypeScript autocompletion.src/models.ts
Models.Document.AnyDocumentextendingModels.Documentwith the string index signature.src/services/databases.ts
createDocumentmethod to useT extends Models.Document = Models.AnyDocument.dataparameter type toOmit<T, keyof Models.Document>.For more details, open the Copilot Workspace session.