feat: Add S3 artifact repository configuration options for parallel transfers and resource limits #14571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usulkies
requested review from
Joibel,
terrytangyuan and
sarabala1979
as code owners
…ransfers and resource limits Signed-off-by: usulkies <[email protected]> Signed-off-by: Uziel Sulkies <[email protected]>
usulkies
force-pushed
the
uziel/s3_parallel
branch
from
4c09dff to
c52f206
Compare
Signed-off-by: Uziel Sulkies <[email protected]>
- Implement parallel directory uploads/downloads using worker pools - Add ParallelTransfers, MultipartPartSize, MultipartConcurrency config options - Support environment variable overrides (ARGO_S3_PARALLEL_TRANSFERS, etc.) - Auto-detect optimal parallelism based on CPU count when not configured - Add comprehensive test coverage for parallelism and configuration options - Improve memory efficiency for large directory operations using streaming approach This addresses performance issues with large S3 directory operations by enabling concurrent file transfers while maintaining backward compatibility. Signed-off-by: Uziel Sulkies <[email protected]>
Signed-off-by: Uziel Sulkies <[email protected]>
Joibel
requested changes
Jun 18, 2025
Signed-off-by: Uziel Sulkies <[email protected]>
Signed-off-by: Uziel Sulkies <[email protected]>
Signed-off-by: Uziel Sulkies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add S3 artifact repository configuration options for parallel transfers and resource limits
Fixes #12442, #9022, #4014
Motivation
The current S3 artifact repository implementation has several limitations that can cause performance and stability issues:
Modifications
Added configuration options for S3 artifact repository:
parallelTransfers: Control number of concurrent transfers (default: runtime.NumCPU()*2, capped at 32)multipartPartSize: Size of each part in multipart uploads (default: 5MB)multipartConcurrency: Number of concurrent multipart uploads (default: 4)Implemented worker pool for parallel transfers:
workflow/artifacts/common/pool/pool.gofor managing concurrent operationsAdded resource limits configuration:
Verification
Unit tests:
Performance testing:
Documentation
Updated S3 artifact repository configuration documentation:
Added code comments explaining: