Chore/bench touch unused deps #1021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookingypq
commented
Aug 26, 2025
cookingypq
commented
- Commit: bench: add minimal bench to exercise ark-ff/ec/serialize deps
- Branch: chore/bench-touch-unused-deps
- Change 'curves repository' to 'curves directory' with relative links - Update minimum Rust version from 1.51+ to 1.56+ to match CHANGELOG
cookingypq
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
Pratyush
reviewed
Sep 9, 2025
|
|
||
| ## Build guide | ||
|
|
||
| The library compiles on the `stable` toolchain of the Rust compiler (v 1.51+). To install the latest version of Rust, first install `rustup` by following the instructions [here](https://rustup.rs/), or via your platform's package manager. Once `rustup` is installed, install the Rust toolchain by invoking: | ||
| The library compiles on the `stable` toolchain of the Rust compiler (v 1.56+). To install the latest version of Rust, first install `rustup` by following the instructions [here](https://rustup.rs/), or via your platform's package manager. Once `rustup` is installed, install the Rust toolchain by invoking: |
There was a problem hiding this comment.
I think this should be updated; can you check which version is the minimal one required?
Pratyush
reviewed
Sep 9, 2025
| @@ -1,4 +1,4 @@ | |||
| # test-templates | |||
|
|
|||
| **Warning!!!** This package does not implement any tests, but exports templates and macros for testing. | |||
| In order to test arkworks, please run `cargo test` inside [algebra](https://github.com/arkworks-rs/algebra). | |||
| In order to test arkworks, please run `cargo test` inside the algebra directory. | |||
There was a problem hiding this comment.
Suggested change
| In order to test arkworks, please run `cargo test` inside the algebra directory. | |
| In order to test arkworks, please run `cargo test` inside the [`algebra`](../algebra) directory. |
Pratyush
reviewed
Sep 9, 2025
| @@ -1,4 +1,4 @@ | |||
| # bench-templates | |||
|
|
|||
| **Warning!!!** This package does not implement any benchmarks, but exports templates and macros for benchmarking. | |||
| In order to benchmark arkworks, please run `cargo bench` inside [ark-curves](https://github.com/arkworks-rs/algebra/tree/master/curves). | |||
| In order to benchmark arkworks, please run `cargo bench` inside the curves directory. | |||
There was a problem hiding this comment.
Suggested change
| In order to benchmark arkworks, please run `cargo bench` inside the curves directory. | |
| In order to benchmark arkworks, please run `cargo bench` inside the [`curves`](../curves) directory. |
Pratyush
reviewed
Sep 9, 2025
Comment on lines
+5
to
+12
| fn bench_deps(c: &mut Criterion) { | ||
| let mut g = c.benchmark_group("deps_touch"); | ||
| let a: ark_ff::BigInt<1> = ark_ff::BigInt::from(123u64); | ||
| let _ = a; | ||
| let _ = ark_serialize::Compress::Yes; | ||
| g.bench_function("noop", |b| b.iter(|| ())); | ||
| g.finish(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.