Skip to content

Conversation

michaelhtm
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler February 17, 2025 20:58
@michaelhtm michaelhtm force-pushed the rt-v0.43.0 branch 2 times, most recently from 11e0a33 to 1f4f17e Compare February 17, 2025 21:26
@michaelhtm
Copy link
Member Author

/retest

1 similar comment
@michaelhtm
Copy link
Member Author

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ack-prow ack-prow bot added the approved label Feb 17, 2025
@michaelhtm
Copy link
Member Author

/retest ec2-controller-test

Copy link

ack-prow bot commented Feb 17, 2025

@michaelhtm: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test acm-controller-test
  • /test apigatewayv2-controller-test
  • /test cloudfront-controller-test
  • /test documentdb-controller-test
  • /test dynamodb-controller-test
  • /test ec2-controller-test
  • /test ecr-controller-test
  • /test efs-controller-test
  • /test eks-controller-test
  • /test eventbridge-controller-test
  • /test iam-controller-test
  • /test lambda-controller-test
  • /test pipes-controller-test
  • /test prometheusservice-controller-test
  • /test s3-controller-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test s3-olm-test
  • /test verify-attribution

Use /test all to run all jobs.

In response to this:

/retest ec2-controller-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelhtm
Copy link
Member Author

/test ec2-controller-test

Copy link

ack-prow bot commented Feb 17, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 47feec7 link true /test ec2-controller-test
verify-attribution 47feec7 link false /test verify-attribution
s3-olm-test 47feec7 link false /test s3-olm-test
eks-controller-test 47feec7 link true /test eks-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests look flaky. Merging as is.
/lgtm

Thanks @michaelhtm !

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
Copy link

ack-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly merged commit 66c0f84 into aws-controllers-k8s:main Feb 17, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants