Postgresql - Error - No Driver has been registered with name

[indrayanivaze]

I am using aws secrets manager to connect to postgresql db hosted on aws. When I try to run locally with groovy grails app, everything works seamlessly without any errors. But when I try to deploy war on tomcat 8, I see the error :

Caused by: java.lang.IllegalStateException: No Driver has been registered with name, org.postgresql.Driver. Please check your system properties or secretsmanager.properties for typos. Also ensure that the Driver registers itself.
	at com.amazonaws.secretsmanager.sql.AWSSecretsManagerDriver.getWrappedDriver(AWSSecretsManagerDriver.java:244)
	at com.amazonaws.secretsmanager.sql.AWSSecretsManagerDriver.acceptsURL(AWSSecretsManagerDriver.java:257)
	at com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:83)
	at com.zaxxer.hikari.pool.PoolUtilities.initializeDataSource(PoolUtilities.java:114)

[daniel097541]

Did you solve this?

[indrayanivaze]

Nope, I haven't got a solution for it. One of the solutions that raghusujju gave was - "I overritten getDefaultDriverClass method inside AWSSecretsManagerPostgreSQLDriver.java ( as I was using postgres) to load the postgresql driver. JUst do a Class.forName("org.postgresql.Driver", false, this.getClass().getClassLoader());. AFter this the issue with driver load was gone.". But I have not tried it yet

[daniel097541]

I solved it, you will need to copy the whole class: AWSSecretsManagerPostgreSQLDriver and add it into your code, this is because their class is final and cannot be extended, then modify the static brackets where they instanciate the driver and instanciate a new org.postgresql.Driver just before, this is working for me:
https://pastebin.com/rTWGPYPU

[indrayanivaze]

ohh.. Thank you very much for letting me know that it worked ...In all did you create 2 classes ? CustomAWSSecretsManagerPostgreSQLDriver and CustomAWSSecretsManagerDriver ? Do you mind also adding imports ? I am seeing some issues with the imports

[shmam]

Encountered this same issue, and only solved it by editing the source code and instantiating a new instance of the default driver. Would like to see this resolved without having to edit the source code though. Is there any way to get this addressed by the devs?

[ehelbig1]

Can this change be added to the repo? Happy to create a PR if that will help expedite things.

[fridovanorden]

Would be a very welcome addition.
If done properly in the AWSSecretsManagerDriver class all other supported databases benefit as well. Best place IMO is in the getWrappedDriver() method:

protected void ensureRealDriverRegistered() {
	try {
	// Load the real driver through the same class loader as the wrapper
	Class<Driver> cls = (Class<Driver>) getClass().getClassLoader().loadClass(this.realDriverClass);
	DriverManager.registerDriver(cls.getDeclaredConstructor().newInstance()); 
} catch (Exception e) {
	e.printStackTrace();
}
}

public Driver getWrappedDriver() {
	ensureRealDriverRegistered();
     // existing code here 

What's wrong in the current implementation is that getWrappedDriver() assumes the driver registers itself. This has two problems:
a) not all drivers register themselves upon class loading
b) if the connection is created e.g. in Tomcat, the real driver class is never loaded by the container (it only sees the wrapper driver class name) and hence there's no chance the driver ever registers itself.

[realvictorprm]

And the problem still remains open :/

[devdeepak02]

This thread was a life saver. thank you.

[willtong1234]

This looks like a duplicate of #26, but I'll keep it open until we can confirm it is indeed the same issue. We are looking into it.

[garg01puneet]

@indrayanivaze can you please share if you are able to make workaround for this?
@fridovanorden are you suggesting to change the source code of this jar?

@willtong1234 , can you please update if any solution for this is available, or if any suggested workaround is available for this?

[jinspark-lab]

Same error with mysql Driver. Any workaround? It is so complicated to change all codes.

[lludsubaru]

I guess people still using Tomcat are too old-school? But I'm using it ( beanstalk ) and trying to use PostgreSQL. I added this code ( including setting initialization to true ) to my version to get it to work. I don't have ( easy ) access to the other databases so can't easily test if it works for anything else. If this is just specific to PostgreSQL maybe I should just add code in the PostgreSQL class.

public Driver getWrappedDriver() {
      try {
        Class.forName( this.realDriverClass, true, this.getClass().getClassLoader() );
      } catch( ClassNotFoundException ex ) {
        throw new IllegalStateException( "Unable to pre-load (Class.forName) "+this.realDriverClass+" to force initialization" );
      }