Skip to content

Server linting #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2024
Merged

Server linting #522

merged 5 commits into from
Jul 31, 2024

Conversation

kmcginnes
Copy link
Collaborator

Description

Adds linting to the server code

  • Updates eslint-plugin-react for flat file configs
  • Removes ignore entry for server code
  • Fix lint errors in node-server.ts
  • Add server code to pnpm check:types

Validation

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk July 31, 2024 22:44
@kmcginnes kmcginnes marked this pull request as ready for review July 31, 2024 22:44
@kmcginnes kmcginnes merged commit 77bae73 into aws:main Jul 31, 2024
1 check passed
@kmcginnes kmcginnes deleted the server-linting branch July 31, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vkagamlyk vkagamlyk vkagamlyk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmcginnes @vkagamlyk