Uncaught TypeError: statements is not iterable

[shankhadevpadam]

laravel-debugbar/src/Resources/queries/widget.js

Line 113 in c0bee7c

identifyDuplicates: function(statements) {

[jonathan-bird]

+1 on this new bug

[tpetry]

Do you have some more informations? Because for statements not to be iterable it must be something else than an array. And I dont know currently how that should be possible.

[jonathan-bird]

@tpetry statements is undefined for me.

Probably unhelpful, but I run the latest version of everything (PHP, Laravel, Chrome etc)

[barryvdh]

Should there be any queries? Or are you not running them?

[jonathan-bird]

Yeah there's lots of queries being run, they're not showing up in the Queries tab and this is the console error. Let me know if there's anything specific you'd like me to check.

[barryvdh]

Can you see what 'statements' actually contains? Either in the json from storage or sourcecode?

[jonathan-bird]

@barryvdh I checked this.identifyDuplicates(data.statements); and data returned empty array, thus causing data.statements to be undefined when passed to the method.

This was checked within:

this.bindAttr('data', function (data) {
  this.identifyDuplicates(data.statements);

  this.renderStatus($status, data);
  $list.set('data', data.statements);
});

[jonathan-bird]

Doesn't seem to be an error on all pages though, just some. I double checked that there are queries being run on that page that has the error occurring too.

[tpetry]

Can you try finding out which exact version broke this? Oh and a full stack trace would be great too.

[barryvdh]

Or maybe disable the EXPLAIN options, or other options in the config for DB collector?

[tpetry]

Or maybe disable the EXPLAIN options, or other options in the config for DB collector?

The EXPLAIN option is only for interactivity after loading it first. This seems to be a general issue with the query widget.

[jonathan-bird]

@tpetry Confirmed working in v3.13.5 but not working in v3.14.0. Have reverted by config to the default just in case there was a discrepancy too but no luck there.

[bennettblack]

I'm seeing this error too with v3.14; I noticed it causes the "queries" tab to be empty. The error goes away when I disable with_params in the config.

[tpetry]

I'm seeing this error too with v3.14; I noticed it causes the "queries" tab to be empty. The error goes away when I disable with_params in the config.

Thats more strange. Because that option changes how the SQL is rendered - and nothing about the list.

Can you reduce your script to a single query that affects the issue? Or at least to as less as possible? And then dd() the $data in the QueryCollector:: collect() method at the end? Once with disabled and once with enabled? As we don't experience the issue we need to see the data whether something is off.

[bennettblack]

@tpetry After doing some digging, it looks like this is failing Laravel-side here:

// QueryCollector.php @getSqlQueryToDisplay
DB::connection($query['connection'])->getQueryGrammar()->substituteBindingsIntoRawSql($sql, $query['bindings'] ?? []);

I'm using a custom DB driver that doesn't support escaping values. This worked with previous versions, I'm guessing some of the new collector changes might have affected this. In my case, I can handle this with my driver.