GitHub workflow improvements #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obsolete since prefer-lowest is no longer run
Since there is an exclusion, this probably was already meant to be included
erikn69
reviewed
Oct 12, 2023
parallels999
approved these changes
Oct 13, 2023
erikn69
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a follow-up to #1474, as I was doing this myself, then found out there already was a PHP 8.3 PR, so please merge that first; this is based on the branch to prevent merge conflicts).
When updating the workflow, I noticed a few things that could be slightly improved:
fix-csworkflownesbon/carbonversion requirement inrun-testsas it is no longer neededrun-integrations-test, which was probably already meant to be there