Skip to content

Conversation

sarunas-k
Copy link
Contributor

Removes if condition to skip test

Looks like it's not relevant because ini settings value isn't used.
Default IDE editor is defined in app.config. Xdebug extension enabled or disabled result doesn't change.

src/LaravelDebugbar.php

$this->editorTemplateLink = $config->get('debugbar.editor') ?: null;`
...
$collector->setEditorLinkTemplate($this->editorTemplateLink);

collect() method ignores ini settings

if (empty($this->xdebugLinkTemplate) && !empty(ini_get('xdebug.file_link_format'))) {
        $this->xdebugLinkTemplate = ini_get('xdebug.file_link_format');
}

return $this->xdebugLinkTemplate;

@sarunas-k sarunas-k changed the title Removes if condition to skip test Removes condition to skip test Aug 4, 2024
@sarunas-k sarunas-k changed the title Removes condition to skip test Remove condition to skip test Aug 4, 2024
@barryvdh barryvdh merged commit de8016c into barryvdh:master Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants