Skip to content

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 26, 2022

Closes #1204.

Changes proposed:

  • Move the glossary to the main part of the specification, under the changelog.
  • Reorder appendices.
  • Remove numbering from appendix titles and filenames.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1256 (c31c3c1) into master (9ad23e8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files           6        6           
  Lines        1055     1055           
=======================================
  Hits          934      934           
  Misses        121      121           
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/render.py 92.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@effigies
Copy link
Collaborator

Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
@tsalo tsalo requested a review from Remi-Gau August 31, 2022 21:18
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we merge this we need to push adjustments to the NIRS pr

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look and nothing stands out as out of order.

@tsalo
Copy link
Member Author

tsalo commented Sep 1, 2022

This now has three approvals. I'm thinking this change is big enough that we should wait the 5 days. What do you all think?

@sappelhoff sappelhoff added this to the 1.8.0 milestone Sep 1, 2022
@sappelhoff sappelhoff merged commit b4f51da into bids-standard:master Sep 11, 2022
@sappelhoff
Copy link
Member

thanks @tsalo

@sappelhoff sappelhoff changed the title [REF] Reorder appendices [MISC] Reorder appendices Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize appendices
4 participants