Skip to content

Conversation

qian-chu
Copy link
Contributor

@qian-chu qian-chu commented Mar 24, 2025

In the example:

  1. Modality ieeg was missing from the filetree
  2. sub and ses in the photo prefix didn't match the actual names
  3. Remove unintended break

@qian-chu qian-chu requested a review from ezemikulan as a code owner March 24, 2025 19:07
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (44d8461) to head (2a436d7).
Report is 181 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2091   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          17       17           
  Lines        1524     1524           
=======================================
  Hits         1266     1266           
  Misses        258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@qian-chu
Copy link
Contributor Author

qian-chu commented Apr 7, 2025

Does anyone else want to take a look at the correction? Thanks!
(PS Error seems to come from an unrelated link issue shared with other PRs.)

@effigies
Copy link
Collaborator

I think we should proceed by lazy consensus here, as this is a minor fix, not a new feature. I'm going to waive the second review requirement and merge, but others should feel free to back this out if it turns out they disagree.

@effigies effigies merged commit 0fdcbd8 into bids-standard:master Apr 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants