-
Notifications
You must be signed in to change notification settings - Fork 187
[ENH] BEP 003: Common Derivatives #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 173 commits
Commits
Show all changes
236 commits
Select commit
Hold shift + click to select a range
58dcce7
Adding derivatives
chrisgorgo ed96fda
adding derivatives to the index
chrisgorgo 9a15097
rename
chrisgorgo 2e6d5e7
rename
chrisgorgo 9557d9c
fix index
chrisgorgo 32d0b33
fixed links
chrisgorgo 99a1ccc
fixed links
chrisgorgo 567f329
template cleanup
chrisgorgo 5ef3b65
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli 548b435
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli a2fd24b
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli 5cbf9e3
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli 0d1bf41
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli 5ce9347
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli a5917b1
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli 0f29a1f
Update src/05-derivatives/05-diffusion-derivatives.md
francopestilli cdb835f
Merge branch 'master' of github.com:bids-standard/bids-specification …
chrisgorgo b515b04
syntax fixes
chrisgorgo 447c63b
remove old extensions
chrisgorgo 6122053
Merge branch 'master' of github.com:bids-standard/bids-specification …
chrisgorgo 43017d1
Update src/99-appendices/08-coordinate-systems.md
satra df3b737
Update src/99-appendices/08-coordinate-systems.md
satra af0ff9a
bring back space
chrisgorgo 140868b
Update src/05-derivatives/01-introduction.md
effigies df9fee6
Update src/05-derivatives/01-introduction.md
effigies 8dc0d1b
Update src/05-derivatives/02-common-data-types.md
yarikoptic 8182a8b
Update src/99-appendices/08-coordinate-systems.md
effigies a519499
Update src/05-derivatives/02-common-data-types.md
effigies a97a5ad
Update src/05-derivatives/02-common-data-types.md
effigies 2c41d50
Update src/05-derivatives/03-structural-derivatives.md
effigies cf3e990
Update src/05-derivatives/03-structural-derivatives.md
effigies 7351e2a
Update src/05-derivatives/03-structural-derivatives.md
effigies b941c3c
fix formatting
chrisgorgo 06a2560
Merge branch 'master' of github.com:bids-standard/bids-specification …
chrisgorgo eec7a3e
added a rule concerning pipline_name consistency
chrisgorgo efd1cf0
fix spaces
chrisgorgo e0f82da
get rid of derivatived
chrisgorgo be7f547
add mention of source data in stanalone derivatives datasets
chrisgorgo c6fc93f
fix label T1w example
chrisgorgo 0c52a0d
fix missing bracket
chrisgorgo a75283d
add missing 'w' in T2w
chrisgorgo 672585c
Limit number of allowed suffixes for scalar derivatives
chrisgorgo f549b42
Update src/99-appendices/08-coordinate-systems.md
effigies e2c3d39
adding CODEOWNERS
chrisgorgo 0693c4b
Merge branch 'enh/derivatives' of github.com:chrisfilo/bids-specifica…
chrisgorgo 6864ba9
adding missing end line
chrisgorgo 374a85d
fix syntax
chrisgorgo 0c1d4a8
removing group
chrisgorgo a6f55ee
[ENC] getting rid of type- key
edickie 101bc95
Merge pull request #3 from edickie/patch-1
chrisgorgo 12ff0a6
bringing back space
edickie 1e2cc33
clarify allowed values for 'space'
chrisgorgo 7be89b7
adding volumetric template used in in HCP
chrisgorgo 06ee174
Merge pull request #4 from edickie/patch-2
chrisgorgo bec8c23
added HCP spaces and introduced hybrid spaces
chrisgorgo a30ed5a
shorten labels, add links
chrisgorgo ea2bc96
Various proposed changes to diffusion derivatives
Lestropie ecbbe14
Derivatives: Diffusion: Tractography: Split "Parameters" dictionary
Lestropie 797c9b6
FIX: Link subsections in functional derivatives
effigies e777e1d
Merge pull request #7 from effigies/fix/subsection_links
chrisgorgo a5ef0c1
MNIfsLR32k + clarifications
chrisgorgo 7e4fa68
small fixes
chrisgorgo a3f70f3
Merge branch 'enh/derivatives' of github.com:chrisfilo/bids-specifica…
chrisgorgo 394efeb
remove transforms since they are not part of this PR
chrisgorgo 7540011
remove transforms since they are not part of this PR
chrisgorgo da97988
Merge branch 'enh/derivatives' into enh/derivatives
Lestropie 8f9c92e
ENH: Rename regressors.tsv to timeseries.tsv
effigies a9fd0fe
Typo
effigies 2d386ff
ENH: Rework metadata description
effigies c3c9377
FIX: Subsection name, link
effigies d33fbe9
RF: Remove "regressor" term
effigies 2ecdbde
adding myself to contributers
edickie 79e3f8d
STY: Slightly less repetitive wording
effigies 27bb9a3
Merge pull request #2 from effigies/enh/derivatives
chrisgorgo 78a9350
Merge pull request #8 from edickie/patch-1
chrisgorgo 132cb3e
HCPMNI
chrisgorgo 100432a
Merge pull request #5 from chrisfilo/enh/cifti_spaces
chrisgorgo 4aab67e
fix syntax
chrisgorgo dcc5642
fix syntax (for realz now)
chrisgorgo b2c7eeb
adding very inflated surfaces
edickie 1a5f03c
Merge pull request #10 from edickie/patch-3
chrisgorgo bd00db2
Update src/05-derivatives/05-diffusion-derivatives.md
oesteban bb67fd7
[INFRA] Adding instructions for naming PRs
chrisgorgo 4e08507
REF: initial rewriting of coordinate system keys
satra e7aae15
Update src/05-derivatives/01-introduction.md
chrisgorgo 32183c2
Further widespread changes to diffusion derivatives
Lestropie 18dc84f
Resolve build issues in diffusion derivatives
Lestropie fe07487
Further resolution of build issues in diffusion derivatives
Lestropie bc773d6
Merge pull request #11 from satra/enh/coordinates
chrisgorgo c42c4bb
fixes
chrisgorgo abf6e8f
[ENH] CoordinateSystem clarifications and examples
chrisgorgo 617e00a
[ENH] CoordinateSystem clarifications and examples
chrisgorgo c7c135e
address Satra's comments
chrisgorgo 1c7d9df
address Satra's comments
chrisgorgo aa16797
Merge branch 'master' of github.com:bids-standard/bids-specification …
chrisgorgo 84ee5d4
Merge branch 'master' of github.com:bids-standard/bids-specification
chrisgorgo 3bd3543
Merge branch 'master' into enh/derivatives
chrisgorgo dc4b48a
fix a link typo
chrisgorgo 900a2b0
removal of the Definition section in Coordinate Spaces appendix
chrisgorgo b0d15dd
Update src/99-appendices/08-coordinate-systems.md
effigies 08f6e8a
Update src/99-appendices/08-coordinate-systems.md
effigies 497adf4
Merge branch 'enh/derivatives' into enh/space_examples
chrisgorgo 4b18cb4
Merge branch 'enh/space_examples' of github.com:chrisfilo/bids-specif…
chrisgorgo 999723a
fixes
chrisgorgo efd026d
adding desc to structural derivatives
chrisgorgo a78065a
Merge branch 'enh/derivatives' into enh/space_examples
chrisgorgo b97c7f0
anat->native + cleanup
chrisgorgo 7f8fb99
cleaning leftover anat's
chrisgorgo 26653c9
fix syntax
chrisgorgo 3878971
clarify links between raw and derived datasets
chrisgorgo fd1fb89
fixes
chrisgorgo 93b2e17
native -> individual
chrisgorgo bbb27a4
bringing back custom space
chrisgorgo ccc33be
add volspace for meshes
chrisgorgo 319b580
fixes
chrisgorgo fcb7967
ReferenceMap -> SpatialReference
chrisgorgo 6fac7ec
Merge pull request #12 from chrisfilo/enh/space_examples
chrisgorgo e43e566
Merge branch 'master' of github.com:bids-standard/bids-specification …
dd7f997
Merge pull request #109 from chrisgorgo/enh/derivatives
chrisgorgo 4ebc41a
Merge branch 'master' into derivatives
effigies 74ff6d0
Diffusion derivatives: Further fixes for #205
Lestropie 1d0613e
Diffusion derivatives: Formatting
Lestropie 41ecca4
Diffusion derivatives: Further fix of superscript usage
Lestropie fd9a572
Diffusion derivatives: Fix error in DKI & WMTI model descriptions
Lestropie 6f788a5
Diffusion derivatives: Use subscripts in model descriptions
Lestropie f28ba08
DOC: really minor typo
yarikoptic b48d068
Merge pull request #205 from Lestropie/enh/derivatives
francopestilli d44d712
ENH: use <label> for _desc- - not some <value> + clarify <value>
yarikoptic cf47f33
Merge pull request #224 from yarikoptic/enh-desc-label
effigies 4a0506a
Merge remote-tracking branch 'upstream/master' into derivatives
effigies 75f4367
Merge remote-tracking branch 'upstream/master' into derivatives
effigies 5069065
FIX: Apply suggestions from @sappelhoff review
effigies 9d281fe
FIX: Code block with indentations
effigies 78f8143
ENH: Use pymdownx.superfences
effigies 35899c8
FIX: Language for code block, missing comma
effigies 0821f71
Drop modality-specific derivatives for now
effigies 6ee22e2
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies bcf6406
ENH: Restore derivative sub-BEPs to BEP list for now
effigies e4a4d65
FIX: Remove modality-specific files from mkdocs.yml
effigies f880fff
Apply suggestions from code review
effigies ac1c4fe
Apply suggestions from code review
effigies e1de6de
FIX: Table alignment
effigies 064cad4
FIX: Consistent list
effigies 442b98d
FIX: Weird list style
effigies 96294ae
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies cad13dd
FIX: Weird list style
effigies 8584fc7
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 7bde6ce
FIX: Clarify naming derivatives after pipeline
effigies 85c54ea
RF: Abstract PipelineDescription.Container from Docker and Singularit…
effigies 64d306a
Pacify linkchecker
effigies 9f95aa6
[STY] Add missing table fence
oesteban 5b037cd
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 6921e62
[SPEC] Separate out imaging-specific "common derivatives"
effigies 2bc990d
ENH: Clarify data type, EEG examples, space/desc wording
effigies c384f97
[STY] Remove blank lines
effigies 10a9a71
Merge pull request #310 from effigies/common-imaging
effigies 49314d0
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 5e90628
MAINT: Update TOC, CODEOWNERS
effigies 9268670
ENH: Add language around non-compliant derivative datasets and files
effigies dbdcfbc
STY: Drop double newline
effigies 6ca0598
STY: Fix link style
effigies 70dc262
Update src/05-derivatives/01-introduction.md
effigies 2c5db7c
Update src/02-common-principles.md
effigies 54f6281
Merge pull request #334 from effigies/fix/relaxation
effigies dbc38b0
Merge branch 'master' into common-derivatives
effigies 4fa236f
specify further the pipeline following #345
e793715
Update src/05-derivatives/01-introduction.md
fe17c4c
Update src/05-derivatives/01-introduction.md
7b418ea
Update src/05-derivatives/01-introduction.md
28b2b59
Update src/05-derivatives/01-introduction.md
33de3f1
Merge pull request #358 from bids-standard/CPernet-patch-1
effigies 45d93f9
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies c200cff
FIX: Links to coordinate system appendix
effigies dd626c1
[FIX] Revise template-generated coordinate systems (#307)
oesteban a4c190c
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 8cd172a
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 2753da1
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 4550458
STY: Grey -> Gray
effigies facda86
Update derivatives introduction with Oscar's suggestions
effigies 002f763
Accept Oscar's suggestions for common data types
effigies 97cd4d0
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies f18b77f
BF: minor - mising _ before space following <source_keywords>
yarikoptic cda4fb2
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 1fe71b8
FIX: Minor bugs
effigies a7beb3d
[ENH] Add ``res`` and ``den`` keywords to indicate resolution of resa…
oesteban e5b41c0
MNT: Postpone thickness GIFTI example to structural derivatives
effigies ead9a84
ENH: Apply Robert's suggestions
effigies 9aaf323
Update BIDSVersion in derivatives example JSON
effigies 83b2fae
ENH: Update wording for clarity
effigies 89566f1
dparc -> dseg
effigies bb90961
STY: Drop quotes in dseg.tsv and reformat with spaces
effigies 94f1814
Update link, conform RFC2119 terms
effigies 2841b34
Use relative paths
effigies 2d9923c
Add resolution/density to masks and segmentations
effigies 5f620fd
STY: Typo
effigies 0d4c1a0
MNT: Drop admonition for now
effigies debe853
Preface for individual/study templates
effigies d95e799
Revert to pre-derivatives description of XXXCoordinateSystem
effigies e0102fc
FIX: Rename derivative directories to use <pipeline>-<variant>
effigies 56c1d98
Apply suggestions from code review
effigies b21a9b8
FIX: Clarify recommendation of desc to when no other entity suits
effigies 82be287
Update examples with T1w, events, EDF (EEG)
effigies 0e2fcd2
ENH: Drop "dictionary" for JSON "object"
effigies 9efc022
Rename PipelineDescription to GeneratedBy, rework table and examples,…
effigies fa5808e
FIX: More dictionary -> object
effigies 8a6821c
Do not abbreviate abbreviation
effigies 6a91d34
Rename: keyword -> entity
effigies 80cc32f
Rewrite Sources description to clarify the A/B/C and X/Y/Z examples
effigies ddcec7a
More cleanup
effigies 1c0ed0a
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies 7ef9a9d
Update src/05-derivatives/03-imaging.md
effigies 55d54ea
Reorganize derivatives
effigies bbd0df1
STY: Clean up links, formatting, outdated text
effigies 6817af9
Fix link
effigies 1f1b46d
Update TOC
effigies fa78c94
Make dataset description example consistent with folder name example
effigies ded6875
Remove RawSources overlap with SpatialReference, some additional clar…
effigies 5af5c1e
ENH: Change single ROI binary image suffix from dseg to mask
effigies 9f1d3a0
Improve wording
effigies 4225839
Clarify discrete surface segmentations
effigies 82fab3d
Swap mapping/color and add an example dseg with new labels
effigies 18d462d
Replace "tissue class" with more general "anatomical structure"
effigies e0508a7
Add labels for masks
effigies b1d64ff
Update src/05-derivatives/03-imaging.md
effigies 20b2269
Fix section links, capitalization
effigies 5dd98d2
Drop "Gray and White Matter" label
effigies f43c0d4
Drop extraneous line, make punctuation consistent
effigies 37c2bf2
Missing paren
effigies 02408bf
Apply suggestions from code review
effigies f9734a5
Apply suggestions from code review
effigies 95c4af7
Update src/05-derivatives/03-imaging.md
effigies 131160c
Update src/05-derivatives/03-imaging.md
effigies 0aaa881
Update src/05-derivatives/03-imaging.md
effigies 3096fbe
Update src/05-derivatives/03-imaging.md
satra 7bfc0e4
ENH: Add RECOMMENDED DatasetType key to dataset description (#494)
effigies affa960
Merge remote-tracking branch 'upstream/master' into common-derivatives
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/04-modality-specific-files/04-intracranial-electroencephalography.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.