[MISC] fix links, make json object links consistent, fix pandoc rendering #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link from code section to sourcedata section
sappelhoff
commented
Aug 31, 2020
Comment on lines
+138
to
+140
| Storing actual source files with the data is preferred over links to | ||
| external source repositories to maximize long term preservation, | ||
| which would suffer if an external repository would not be available anymore. |
There was a problem hiding this comment.
These sentences come from the code section. The code section now contains a link to this section instead.
see: #587 (comment)
sappelhoff
commented
Aug 31, 2020
Comment on lines
-377
to
-379
| <sup>1</sup>Storing actual source files with the data is preferred over links to | ||
| external source repositories to maximize long term preservation (which would | ||
| suffer if an external repository would not be available anymore). |
There was a problem hiding this comment.
these lines are now in the sourcedata section: #587 (comment)
and as you can see above, the code section now links to that section.
hoechenberger
approved these changes
Aug 31, 2020
Co-authored-by: Richard Höchenberger <[email protected]>
hoechenberger
approved these changes
Aug 31, 2020
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
approved these changes
Aug 31, 2020
hoechenberger
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #565
with this PR:
Derived dataset and pipeline descriptioncodesection and intertwine it more withsourcedatasection